Hello,
today, voting for ldap_modify_batch [1] ended with 5 votes in favor
and none against.
I have two questions regarding the rest of the process, given that
this is my first contribution to the PHP project:
-
What would be the easiest way to supply the changes to the project?
Open a pull request on Github? Send a patch to someone? -
Which version should ldap_modify_batch land in? Only in 5.6 or will
it be backported? Against which branch should I submit the pull
request or patch? (master? 5.5 (newest stable)? 5.3 (oldest supported
stable)? earliest possible?)
Thanks for your help in advance!
Cheers,
~~ Ondra
Hello,
today, voting for ldap_modify_batch [1] ended with 5 votes in favor
and none against.
Congrats to your first contribution!
I have two questions regarding the rest of the process, given that
this is my first contribution to the PHP project:
- What would be the easiest way to supply the changes to the project?
Open a pull request on Github? Send a patch to someone?
Definitely open a PR on github, that should be the easiest.
- Which version should ldap_modify_batch land in? Only in 5.6 or will
it be backported? Against which branch should I submit the pull
request or patch? (master? 5.5 (newest stable)? 5.3 (oldest supported
stable)? earliest possible?)
Definitely not in 5.3, probably not in 5.4 and IMO fine for 5.5.
So whatever RMs think is appropriate, either 5.5 or 5.6, RMs?
--
Regards,
Mike
- Which version should ldap_modify_batch land in? Only in 5.6 or will
it be backported?Definitely not in 5.3, probably not in 5.4 and IMO fine for 5.5.
So whatever RMs think is appropriate, either 5.5 or 5.6, RMs?
RMs: what's your take on this?
Cheers,
~~ Ondra
- Which version should ldap_modify_batch land in? Only in 5.6 or will
it be backported?Definitely not in 5.3, probably not in 5.4 and IMO fine for 5.5.
So whatever RMs think is appropriate, either 5.5 or 5.6, RMs?RMs: what's your take on this?
Cheers,
~~ Ondra
I agree with Stas here, it could go to 5.4 and upwards.
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
I agree with Stas here, it could go to 5.4 and upwards.
Alright, I've opened a pull request against 5.4:
https://github.com/php/php-src/pull/571
Cheers,
~~ Ondra
Hi!
- Which version should ldap_modify_batch land in? Only in 5.6 or will
it be backported? Against which branch should I submit the pull
request or patch? (master? 5.5 (newest stable)? 5.3 (oldest supported
stable)? earliest possible?)
Looking at the patch, I don't see a problem having it in 5.4 and 5.5.
5.3 is security fixes only, so it can't be there.
And yes, best way to do it is to create a pull on github, let people
review it and then have somebody merge it.
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227