Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:71187 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 30886 invoked from network); 16 Jan 2014 15:04:41 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Jan 2014 15:04:41 -0000 Authentication-Results: pb1.pair.com smtp.mail=mike.php.net@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=mike.php.net@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.177 as permitted sender) X-PHP-List-Original-Sender: mike.php.net@gmail.com X-Host-Fingerprint: 209.85.215.177 mail-ea0-f177.google.com Received: from [209.85.215.177] ([209.85.215.177:52029] helo=mail-ea0-f177.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A7/B1-21406-805F7D25 for ; Thu, 16 Jan 2014 10:04:41 -0500 Received: by mail-ea0-f177.google.com with SMTP id n15so1195211ead.22 for ; Thu, 16 Jan 2014 07:04:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; bh=M1yMUzFUQ9tEx1rvZP/rV9kdw5PtOkeIJDVU2m6Ozjs=; b=to0yguW339iOgQ3mtj6i34YKL7FlcBu5PBru4Fv2/4LLX0L7wqUb7vDVdEysPpg6Og oisGILKkQNLkpmzByL5RZ8kS5R+48qaBln5lzVelESVN6ephIP5t5+Rjcm1pVHmXxGgj Q8mox+7budCUHhz7keF+t2y2gwLbtvo8xSJKcwjhUBN4SL2aPCSCYJDnE/p+krqBjASN wmkXbJFiF7tmTDIJIRNkOrQAjobCOjnvcU0jYPHOkYIsB4TTaM8G3FfNqvpLgXdefWH1 qdnJa9s6HJ6igdxogCY+2Bv6GRI+2KVAkLKF/POOmrpLfMowlwPhTnovXDxcaYMBss6F rWzg== X-Received: by 10.15.74.200 with SMTP id j48mr1630935eey.102.1389884677366; Thu, 16 Jan 2014 07:04:37 -0800 (PST) Received: from [192.168.1.120] (178-18-170-101.customer.bnet.at. [178.18.170.101]) by mx.google.com with ESMTPSA id x2sm16162180eeo.8.2014.01.16.07.04.36 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 16 Jan 2014 07:04:36 -0800 (PST) Message-ID: <1389884675.2057.4.camel@smugmug> To: =?UTF-8?Q?Ond=C5=99ej_Ho=C5=A1ek?= Cc: PHP Internals List , Ferenc Kovacs , Julien Pauli Date: Thu, 16 Jan 2014 16:04:35 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] [RFC] [accepted] ldap_modify_batch From: mike.php.net@gmail.com (Mike) On Thu, 2014-01-16 at 15:17 +0100, Ondřej Hošek wrote: > Hello, > > today, voting for ldap_modify_batch [1] ended with 5 votes in favor > and none against. Congrats to your first contribution! > I have two questions regarding the rest of the process, given that > this is my first contribution to the PHP project: > > 1. What would be the easiest way to supply the changes to the project? > Open a pull request on Github? Send a patch to someone? Definitely open a PR on github, that should be the easiest. > 2. Which version should ldap_modify_batch land in? Only in 5.6 or will > it be backported? Against which branch should I submit the pull > request or patch? (master? 5.5 (newest stable)? 5.3 (oldest supported > stable)? earliest possible?) Definitely not in 5.3, probably not in 5.4 and IMO fine for 5.5. So whatever RMs think is appropriate, either 5.5 or 5.6, RMs? -- Regards, Mike