Hello internals,
It’s been a while since the use-function RFC was accepted (reminder: https://wiki.php.net/rfc/use_function). The last few edge case bugs that had come up have now been fixed. As far as I’m concerned, the patch is complete.
It would be great to get some more review to ensure there are no issues in the implementation. And once that’s done, it can be merged.
The patch is at: https://github.com/php/php-src/pull/526
Thanks,
Igor
Hi,
Just bumping this thread, since it didn’t receive any attention at all.
Thanks,
Igor
Hello internals,
It’s been a while since the use-function RFC was accepted (reminder: https://wiki.php.net/rfc/use_function). The last few edge case bugs that had come up have now been fixed. As far as I’m concerned, the patch is complete.
It would be great to get some more review to ensure there are no issues in the implementation. And once that’s done, it can be merged.
The patch is at: https://github.com/php/php-src/pull/526
Thanks,
Igor
Hi,
Just bumping this thread, since it didn’t receive any attention at all.
Sorry!
Igor, did you fully merge my fixes branch yet?
--
Regards,
Mike
Hi,
Just bumping this thread, since it didn’t receive any attention at all.
Sorry!
Igor, did you fully merge my fixes branch yet?
There's a fix for which I obviously did not create a PR:
https://github.com/m6w6/php-src/compare/igorw:use-function...use-function
--
Regards,
Mike
Hi,
Just bumping this thread, since it didn’t receive any attention at all.
Sorry!
Igor, did you fully merge my fixes branch yet?There's a fix for which I obviously did not create a PR:
https://github.com/m6w6/php-src/compare/igorw:use-function...use-function
I missed that patch. But it looks like Adam did an alternate fix:
If that is not sufficient, can you please send an updated pull request against the current branch?
Thanks!
Igor