Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70116
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain wiedler.ch from 217.26.49.175 cause and error)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\))
In-Reply-To: <CALJZF3hDL--GeKZGCN1Pa54ax_CQiHn2e=U_Z3z20daxZ0s6eA@mail.gmail.com>
Date: Thu, 14 Nov 2013 16:15:26 +0100
Cc: "internals@lists.php.net List PHP" <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <F3E119E0-562D-4FD9-9A70-8BB1B5CADA98@wiedler.ch>
References: <253C51BB-61CF-4E01-9157-EAA926C9159C@wiedler.ch> <65275146-D465-4B0B-8C4D-FFE5E9421977@wiedler.ch> <CALJZF3j0vbGHUKt_TPxgYrNFkVT1qvNzQL91jQuT0L42ejbYpQ@mail.gmail.com> <CALJZF3hDL--GeKZGCN1Pa54ax_CQiHn2e=U_Z3z20daxZ0s6eA@mail.gmail.com>
To: Michael Wallner <mike@php.net>
Subject: Re: [PHP-DEV] Review requested: use-function patch
From: igor@wiedler.ch (Igor Wiedler)

On 14 Nov 2013, at 15:45, Michael Wallner <mike@php.net> wrote:

> On 14 November 2013 15:42, Michael Wallner <mike@php.net> wrote:
>> On 14 November 2013 14:11, Igor Wiedler <igor@wiedler.ch> wrote:
>>> Hi,
>>>=20
>>> Just bumping this thread, since it didn=92t receive any attention at =
all.
>>=20
>> Sorry!
>> Igor, did you fully merge my fixes branch yet?
>=20
> There's a fix for which I obviously did not create a PR:
> =
https://github.com/m6w6/php-src/compare/igorw:use-function...use-function

I missed that patch. But it looks like Adam did an alternate fix:

* =
https://github.com/igorw/php-src/commit/9711c58bc4236c0e2e482af9b20581e78a=
f0c7ca

If that is not sufficient, can you please send an updated pull request =
against the current branch?

Thanks!

Igor