Fixes for documentation in source. Which branch to start? View as Markdown

On Thu, Jul 18, 2013 at 6:19 AM, Sherif Ramadan theanomaly.is@gmail.com
wrote:

On Wed, Jul 17, 2013 at 11:55 PM, Yasuo Ohgaki yohgaki@ohgaki.net
wrote:

Hi all,

Take a look at this PR

https://github.com/php/php-src/pull/351.diff

The documentation in php.ini-* is broken, where should we
fix these kind of error?

From 5.3 branch or 5.4 branch?

5.3 is security fixes only.

Well, I don't see a good enough reason not to commit documentation to
5.3 as well

I suppose you're right since it's not source code, but it remains dubious
that this counts as documentation. If we want to add documentation notes for
this it should go in the manual where we document everything. Not that I'm
the arbiter of what goes in 5.3.

You are welcome to add more (internals or general) documentations to
the manual. But the sources have always contained documentation, the
more the better :)

--
Pierre

@pierrejoye | http://www.libgd.org

Sherif Ramadan wrote:

5.3 is security fixes only.

Well, I don't see a good enough reason not to commit documentation to
5.3 as well

I suppose you're right since it's not source code, but it remains dubious
that this counts as documentation. If we want to add documentation notes
for this it should go in the manual where we document everything. Not that
I'm the arbiter of what goes in 5.3.

It's a bit chicken and egg when it comes to the sample .ini files? Nobody should
be installing a new server from 5.3, just perhaps rebuilding an existing one
where their ini files should already exist? And if they are trying to replicate
an older setup they already have the faulty details. In any case any changes
would not be released until there was a security fix that warrants one?

--
Lester Caine - G8HFL

Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk
Rainbow Digital Media - http://rainbowdigitalmedia.co.uk

5.3 is security fixes only.

Well, I don't see a good enough reason not to commit documentation to
5.3 as well

There is a good reason: Having clean diffs between releases.

Any non archaic tool will let you sort them out easily.