Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:68146 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 97197 invoked from network); 18 Jul 2013 07:18:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Jul 2013 07:18:31 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.48 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.215.48 mail-la0-f48.google.com Received: from [209.85.215.48] ([209.85.215.48:62326] helo=mail-la0-f48.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DB/6F-20914-5C697E15 for ; Thu, 18 Jul 2013 03:18:30 -0400 Received: by mail-la0-f48.google.com with SMTP id lx15so2161778lab.21 for ; Thu, 18 Jul 2013 00:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=glt2VhQp23ihxl6h+o1SLPGvtlIGQLzbu/ZAakMBHhQ=; b=OungqUAumRzNRDLEwaSd3Ca3uvBEQy4ATho+5U40bQ6dViG2FCoj0naLfpRmCZRpam 2cU0e+Y57mQJ2vzxYd5Y4MtOY4cWmyFhMAv50rp3smXWmykQhc3InHSswtXkMki4rP8F dinQRcAWjefUqDKJYKo0oLGJKGMUwcfBbv/vYlYiwOXJP1wIFzwOonfLVLWK8WMGgjAo ny1snMAW6YtXIvIcd8qKibC5TJZqTBhE1nzjCNkzyCp3qvZNOv/O3a3nsDgjxv5fjL2A 7k4jPVCamsbb1aECtCZ7INcXgCJFI+aBHOIWzd7ogIoF34XgfDIOEyze+W0LKcGz1iPA 51vg== MIME-Version: 1.0 X-Received: by 10.112.167.136 with SMTP id zo8mr4654299lbb.33.1374131906996; Thu, 18 Jul 2013 00:18:26 -0700 (PDT) Received: by 10.112.160.4 with HTTP; Thu, 18 Jul 2013 00:18:26 -0700 (PDT) In-Reply-To: References: Date: Thu, 18 Jul 2013 09:18:26 +0200 Message-ID: To: Sherif Ramadan Cc: =?ISO-8859-1?Q?Johannes_Schl=FCter?= , Yasuo Ohgaki , "internals@lists.php.net" Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PHP-DEV] Fixes for documentation in source. Which branch to start? From: pierre.php@gmail.com (Pierre Joye) On Thu, Jul 18, 2013 at 8:53 AM, Sherif Ramadan wrote: > > > > On Thu, Jul 18, 2013 at 1:37 AM, Pierre Joye wrote: >> >> On Thu, Jul 18, 2013 at 6:19 AM, Sherif Ramadan >> wrote: >> > On Wed, Jul 17, 2013 at 11:55 PM, Yasuo Ohgaki >> > wrote: >> > >> >> Hi all, >> >> >> >> Take a look at this PR >> >> >> >> https://github.com/php/php-src/pull/351.diff >> >> >> >> The documentation in php.ini-* is broken, where should we >> >> fix these kind of error? >> >> >> >> From 5.3 branch or 5.4 branch? >> >> >> > >> > >> > 5.3 is security fixes only. >> >> Well, I don't see a good enough reason not to commit documentation to >> 5.3 as well > > > I suppose you're right since it's not source code, but it remains dubious > that this counts as documentation. If we want to add documentation notes for > this it should go in the manual where we document everything. Not that I'm > the arbiter of what goes in 5.3. You are welcome to add more (internals or general) documentations to the manual. But the sources have always contained documentation, the more the better :) -- Pierre @pierrejoye | http://www.libgd.org