Hi,
after quite some some I've been finally able to put my hands again on
PDO. I know the timing is not ideal, but I hope it's not too late for
adding a couple more features and fixes into 5.5.
Namely:
- LISTEN/NOTIFY support https://bugs.php.net/42614
- Additional support for COPY https://bugs.php.net/50092
The former is Postgres' own Publish–subscribe messaging system, which is
already supported by the regular pgsql extension, but it's not available
for those using PDO.
The latter adds low-level functionality to read/write data to tables
without having to rely on arrays or files as in the existing
PDO::pgsqlCopyFromArray etc. Again, something that exists in the pgsql
ext, but not within PDO.
Both features have been ported to 5.5 and are mostly code complete, but
while cleaning them up I've noticed something rather unpleasant.
It appears that error handling in all the existing custom PDO::pgsql*
methods is kind of broken, as they doesn't effectively use PDO's
pdo_handle_error() function, thus they don't trigger any error or
exception at all.
I still think it's worth to fix this for 5.5, and possibly backport the
fixes, but this requires some refactoring to move PDO_HANDLE_DBH_ERR()
and related declarations/macros away from php_pdo_int.h, so they can be
used by the drivers.
Thoughts?
Cheers
Matteo Beccati
Development & Consulting - http://www.beccati.com/
Hi,
after quite some some I've been finally able to put my hands again on
PDO. I know the timing is not ideal, but I hope it's not too late for
adding a couple more features and fixes into 5.5.
Purely bug fixes are probably welcome for PHP 5.5 but new features are not
welcome at this stage of the release process.
I am excited to see development in PDO. Thank you for your interest!
Hi Levi,
thanks for your reply.
after quite some some I've been finally able to put my hands again on
PDO. I know the timing is not ideal, but I hope it's not too late for
adding a couple more features and fixes into 5.5.Purely bug fixes are probably welcome for PHP 5.5 but new features are not
welcome at this stage of the release process.
Fair enough. I still hope for a (little) chance of having the following
commit cherry picked to 5.5: two more undocumented / experimental
PDO_pgsql methods shouldn't hurt anyone ;)
http://git.php.net/?p=php-src.git;a=commitdiff;h=b62b8b45286e7e8a69b04fc6aaf28f838c9a5951
If not, I certainly hope it can be 5.5.1 material rather than 5.NEXT...
I am excited to see development in PDO. Thank you for your interest!
Paid work will probably get in the way soon as usual... unless I can
find some way of getting my PDO work sponsored :D
Anyway, I'd love to see my other recent commits to master reviewed as
they touched common PDO .h files and introduced some BC break, albeit
minimal (undocumented methods).
Cheers
Matteo Beccati
Development & Consulting - http://www.beccati.com/