Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67608
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain beccati.com designates 176.9.114.167 as permitted sender)
Message-ID: <51AB53D2.1030705@beccati.com>
Date: Sun, 02 Jun 2013 16:16:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: PDO_pgsql improvements and fixes
From: php@beccati.com (Matteo Beccati)

Hi,

after quite some some I've been finally able to put my hands again on
PDO. I know the timing is not ideal, but I hope it's not too late for
adding a couple more features and fixes into 5.5.

Namely:
 - LISTEN/NOTIFY support https://bugs.php.net/42614
 - Additional support for COPY https://bugs.php.net/50092

The former is Postgres' own Publish–subscribe messaging system, which is
already supported by the regular pgsql extension, but it's not available
for those using PDO.
The latter adds low-level functionality to read/write data to tables
without having to rely on arrays or files as in the existing
PDO::pgsqlCopyFromArray etc. Again, something that exists in the pgsql
ext, but not within PDO.

Both features have been ported to 5.5 and are mostly code complete, but
while cleaning them up I've noticed something rather unpleasant.

It appears that error handling in all the existing custom PDO::pgsql*
methods is kind of broken, as they doesn't effectively use PDO's
pdo_handle_error() function, thus they don't trigger any error or
exception at all.

I still think it's worth to fix this for 5.5, and possibly backport the
fixes, but this requires some refactoring to move PDO_HANDLE_DBH_ERR()
and related declarations/macros away from php_pdo_int.h, so they can be
used by the drivers.

Thoughts?


Cheers
-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/