ZEND_NS_NAMED_FE is clearly a frequently used macro

13 years ago by Sara Golemon — view source — reply

unread

It's time to play "Spot the double quoting!"

#define ZEND_NS_FENTRY(ns, zend_name, name, arg_info, flags)
ZEND_RAW_FENTRY(ZEND_NS_NAME(ns, #zend_name), name, arg_info, flags)

#define ZEND_NS_NAMED_FE(ns, zend_name, name, arg_info) ZEND_NS_FENTRY(ns,
#zend_name, name, arg_info, 0)

ZEND_NS_NAMED_FE("foo", bar, ...)

Gets exported to userspace as: foo"bar" which is obviously fail.

Any objections to my fixing ZEND_NS_NAMED_FE as: s/#zend/zend/ ?

-Sara

13 years ago by Derick Rethans — view source — reply

unread

It's time to play "Spot the double quoting!"

#define ZEND_NS_FENTRY(ns, zend_name, name, arg_info, flags)
ZEND_RAW_FENTRY(ZEND_NS_NAME(ns, #zend_name), name, arg_info, flags)

#define ZEND_NS_NAMED_FE(ns, zend_name, name, arg_info) ZEND_NS_FENTRY(ns,
#zend_name, name, arg_info, 0)

ZEND_NS_NAMED_FE("foo", bar, ...)

Gets exported to userspace as: foo"bar" which is obviously fail.

Any objections to my fixing ZEND_NS_NAMED_FE as: s/#zend/zend/ ?

That was my thought last night as well when I noticed it...
so go for it :-)

cheers,
Derick