Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67454
Return-Path: <derick@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 42084 invoked from network); 21 May 2013 18:29:01 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 21 May 2013 18:29:01 -0000
Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender)
X-PHP-List-Original-Sender: derick@php.net
X-Host-Fingerprint: 82.113.146.227 xdebug.org Linux 2.6
Received: from [82.113.146.227] ([82.113.146.227:33847] helo=xdebug.org)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id D0/BC-62204-AECBB915 for <internals@lists.php.net>; Tue, 21 May 2013 14:29:01 -0400
Received: from localhost (localhost [IPv6:::1])
	by xdebug.org (Postfix) with ESMTPS id EC008DE14D;
	Tue, 21 May 2013 19:28:55 +0100 (BST)
Date: Tue, 21 May 2013 11:28:54 -0700 (PDT)
X-X-Sender: derick@whisky.home.derickrethans.nl
To: Sara Golemon <pollita@php.net>
cc: PHP internals <internals@lists.php.net>
In-Reply-To: <CAESVnVrH3iCdrS7S6eanV-46os9fSsDaUoU0FsrHQwJ2WdAfEQ@mail.gmail.com>
Message-ID: <alpine.DEB.2.02.1305211128180.5833@whisky.home.derickrethans.nl>
References: <CAESVnVrH3iCdrS7S6eanV-46os9fSsDaUoU0FsrHQwJ2WdAfEQ@mail.gmail.com>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [PHP-DEV] ZEND_NS_NAMED_FE is clearly a frequently used macro
From: derick@php.net (Derick Rethans)

On Tue, 21 May 2013, Sara Golemon wrote:

> It's time to play "Spot the double quoting!"
> 
> #define ZEND_NS_FENTRY(ns, zend_name, name, arg_info, flags)
>  ZEND_RAW_FENTRY(ZEND_NS_NAME(ns, #zend_name), name, arg_info, flags)
> 
> #define ZEND_NS_NAMED_FE(ns, zend_name, name, arg_info) ZEND_NS_FENTRY(ns,
> #zend_name, name, arg_info, 0)
> 
> 
> ZEND_NS_NAMED_FE("foo", bar, ...)
> 
> Gets exported to userspace as: foo\"bar" which is obviously fail.
> 
> Any objections to my fixing ZEND_NS_NAMED_FE as: s/#zend/zend/ ?

That was my thought last night as well when I noticed it...
so go for it :-)

cheers,
Derick