Hi,
I plan to allow php-fpm to be aware of systemd and so, use the
type=notify mode.
I'd like to apply to attached patch to 5.4 and 5.5, as this change have
no impact on standard build (need new --with-fpm-systemd build option).
Any feedback before I process ?
Remi.
Le 17/05/2013 18:44, Remi Collet a écrit :
I plan to allow php-fpm to be aware of systemd and so, use the
type=notify mode.
Just to be clear on the goal, this allow systemd to display some
information about the health of the service (Status line)
systemctl php-fpm.service status
Loaded: loaded (/usr/lib/systemd/system/php-fpm.service; disabled)
Active: active (running) since Fri, 17 May 2013 18:57:43 +0200; 981ms ago
Status: "Processes active: 1, idle: 5, Requests: 656, slow: 2, Traffic:
33.5req/sec"
Main PID: 6670 (php-fpm)
CGroup: name=systemd:/system/php-fpm.service
├ 6670 php-fpm: master process (/etc/php-fpm.conf)
├ 6671 php-fpm: pool www
├ 6672 php-fpm: pool www
├ 6673 php-fpm: pool www
├ 6674 php-fpm: pool www
└ 6675 php-fpm: pool www
Like for apache (with mod_systemd), this information is updated every 10".
Remi.
Hi,
Hi,
I plan to allow php-fpm to be aware of systemd and so, use the
type=notify mode.I'd like to apply to attached patch to 5.4 and 5.5, as this change have
no impact on standard build (need new --with-fpm-systemd build option).Any feedback before I process ?
I can't give technical feedbacks about FPM but the feature is welcome!
Nice idea.
--
Ivan Enderlin
Developer of Hoa
http://hoa-project.net/
PhD. student at DISC/Femto-ST (Vesontio) and INRIA (Cassis)
http://disc.univ-fcomte.fr/ and http://www.inria.fr/
Member of HTML and WebApps Working Group of W3C
http://w3.org/
Le 17/05/2013 18:44, Remi Collet a écrit :
Any feedback before I process ?
From proposal from Jérôme, I have add a new "systemd_interval" option to
configure the interval between 2 systemd notification (0 means disabled,
except initial notification which stay mandatory by design)
Note : this small feature also allow to set the service in watchdog mode
(it will enter "failed" state if systemd don't receive notification
during configured interval). In this case, the watchdog interval
overrides the configured interval option.
Remi.
--------------030306010103010609050002
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bitHi,
I plan to allow php-fpm to be aware of systemd and so, use the
type=notify mode.I'd like to apply to attached patch to 5.4 and 5.5, as this change have
no impact on standard build (need new --with-fpm-systemd build option).Any feedback before I process ?
I saw you already comitted this. As mentioned before, new features
belong to master and not to PHP 5.5.0 which is in RC phase. Therefore
I think this feature shouldnot be added to 5.5.0.
David
Le 23/05/2013 01:04, David Soria Parra a écrit :
--------------030306010103010609050002
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bitHi,
I plan to allow php-fpm to be aware of systemd and so, use the
type=notify mode.I'd like to apply to attached patch to 5.4 and 5.5, as this change have
no impact on standard build (need new --with-fpm-systemd build option).Any feedback before I process ?
I saw you already comitted this. As mentioned before, new features
belong to master and not to PHP 5.5.0 which is in RC phase. Therefore
Sorry for this.
I have raised the discussion some days ago and get no negative feedback,
so I have commited it.
So most of users, this is a no change (only the Type=simple added in the
unit file, which is the default)
I think this feature shouldnot be added to 5.5.0.
AS this small change is also in 5.4.16, I think it will be a bit ugly to
remove it from 5.5.0 and add it later to 5.5.1.
Remi.
David