Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67456
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain fedoraproject.org from 212.27.42.5 cause and error)
Message-ID: <519DA668.2090903@fedoraproject.org>
Date: Thu, 23 May 2013 07:17:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130515 Thunderbird/17.0.6
MIME-Version: 1.0
To: PHP Internals <internals@lists.php.net>
References: <51965E51.80004@fedoraproject.org> <slrnkpqjoi.h43.dsp@experimentalworks.net>
In-Reply-To: <slrnkpqjoi.h43.dsp@experimentalworks.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Re: php-fpm and systemd integration
From: remi@fedoraproject.org (Remi Collet)

Le 23/05/2013 01:04, David Soria Parra a écrit :
> On 2013-05-17, Remi Collet <remi@fedoraproject.org> wrote:
>> --------------030306010103010609050002
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 7bit
>>
>> Hi,
>>
>> I plan to allow php-fpm to be aware of systemd and so, use the
>> type=notify mode.
>>
>> I'd like to apply to attached patch to 5.4 and 5.5, as this change have
>> no impact on standard build (need new --with-fpm-systemd build option).
>>
>> Any feedback before I process ?
> 
> I saw you already comitted this. As mentioned before, new features
> belong to master and not to PHP 5.5.0 which is in RC phase. Therefore

Sorry for this.

I have raised the discussion some days ago and get no negative feedback,
so I have commited it.

So most of users, this is a no change (only the Type=simple added in the
unit file, which is the default)

> I think this feature shouldnot be added to 5.5.0.

AS this small change is also in 5.4.16, I think it will be a bit ugly to
remove it from 5.5.0 and add it later to 5.5.1.

Remi.


> David
>