Hi,
with Felipe's help I've just added the second pull request management
tool to mange pull requests.
The first one is https://qa.php.net/pulls/ this allows any php.net
developer to close pull requests on github, without us having to manage
users on github and adding them to groups and all that stuff. I guess
most of you have seen that.
The new one is a simple integration of pull requests to the bug tracker.
Similar to the "patch" feature of the bug tracker it is meant to link
pull requests from bugs so one can easily use a quick search to find all
bugs with code waiting for a review and having php.net users assigned to
pull requests.
Search for recent bugs with patch or pull request:
https://bugs.php.net/search.php?boolean=0&limit=30&order_by=id&direction=DESC&cmd=display&status=Open&bug_age=0&bug_updated=0&bug_type=All&patch=Y&pull=Y
Search for recent bugs with pull requests only:
https://bugs.php.net/search.php?boolean=0&limit=30&order_by=id&direction=DESC&cmd=display&status=Open&bug_age=0&bug_updated=0&bug_type=All&pull=Y
This is a relatively quick hack with room for improvement, some ideas
anybody can pick up (I'm happy to give a hand where needed):
- Add functionality from qa.php.net/pull for closing pull requests
- Add a note to github when a bug is assigned to a pull request
- Show more details about the pull request
- Improve the usability
- Improve the code
- ...
Happy bug fixing!
johannes
On Wed, Feb 13, 2013 at 11:03 AM, Johannes Schlüter
johannes@schlueters.dewrote:
Hi,
with Felipe's help I've just added the second pull request management
tool to mange pull requests.The first one is https://qa.php.net/pulls/ this allows any php.net
developer to close pull requests on github, without us having to manage
users on github and adding them to groups and all that stuff. I guess
most of you have seen that.The new one is a simple integration of pull requests to the bug tracker.
Similar to the "patch" feature of the bug tracker it is meant to link
pull requests from bugs so one can easily use a quick search to find all
bugs with code waiting for a review and having php.net users assigned to
pull requests.Search for recent bugs with patch or pull request:
https://bugs.php.net/search.php?boolean=0&limit=30&order_by=id&direction=DESC&cmd=display&status=Open&bug_age=0&bug_updated=0&bug_type=All&patch=Y&pull=Y
Search for recent bugs with pull requests only:This is a relatively quick hack with room for improvement, some ideas
anybody can pick up (I'm happy to give a hand where needed):
- Add functionality from qa.php.net/pull for closing pull requests
- Add a note to github when a bug is assigned to a pull request
- Show more details about the pull request
- Improve the usability
- Improve the code
- ...
Happy bug fixing!
johannes
--
Excellent stuff!
I like the idea of having bugs linked to github. Most often I find a great
disconnect between the bugs and github so that idea strikes me as very
convenient since knowing someone is assigned in both places alleviates the
need to go hunting.
Hi Johannes,
quick question: does it automatically open bug reports for each PR?
Am 13.02.2013 um 17:03 schrieb Johannes Schlüter johannes@schlueters.de:
Hi,
with Felipe's help I've just added the second pull request management
tool to mange pull requests.The first one is https://qa.php.net/pulls/ this allows any php.net
developer to close pull requests on github, without us having to manage
users on github and adding them to groups and all that stuff. I guess
most of you have seen that.The new one is a simple integration of pull requests to the bug tracker.
Similar to the "patch" feature of the bug tracker it is meant to link
pull requests from bugs so one can easily use a quick search to find all
bugs with code waiting for a review and having php.net users assigned to
pull requests.Search for recent bugs with patch or pull request:
https://bugs.php.net/search.php?boolean=0&limit=30&order_by=id&direction=DESC&cmd=display&status=Open&bug_age=0&bug_updated=0&bug_type=All&patch=Y&pull=Y
Search for recent bugs with pull requests only:
https://bugs.php.net/search.php?boolean=0&limit=30&order_by=id&direction=DESC&cmd=display&status=Open&bug_age=0&bug_updated=0&bug_type=All&pull=YThis is a relatively quick hack with room for improvement, some ideas
anybody can pick up (I'm happy to give a hand where needed):
- Add functionality from qa.php.net/pull for closing pull requests
- Add a note to github when a bug is assigned to a pull request
- Show more details about the pull request
- Improve the usability
- Improve the code
- ...
Happy bug fixing!
johannes
Hi Johannes,
quick question: does it automatically open bug reports for each PR?
No, for two reasons:
A. Github provides no good notification mechanism for that, we'd
have to pull periodically and match it and so on
B. Many requests are written after bugs were opened, if it would
open bugs automatically we'd have quite a few duplicates and
discussion in three places (initial analysis on initial report,
review discussion at github, final discussion at the new bug)
All this feature currently does is providing a "structured" (relational
database model, yay) way to link from a bug report to github.
I'm happy about any improvements being done, though (part of pushing
this is my hope to motivate some people to think about possibilities and
add better things)
johannes