Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:65794
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1360771381.2694.24.camel@guybrush>
References: <1360771381.2694.24.camel@guybrush>
Date: Wed, 13 Feb 2013 11:15:25 -0500
Message-ID: <CAL+t6cHDeQxWM_mjzQUYdXm9gK1rjhQswVR3SPVn87xxoZNREQ@mail.gmail.com>
To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@schlueters.de>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0122efde26651d04d59d733e
Subject: Re: [PHP-DEV] Github pull request management
From: theanomaly.is@gmail.com (Sherif Ramadan)

--089e0122efde26651d04d59d733e
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 13, 2013 at 11:03 AM, Johannes Schl=FCter
<johannes@schlueters.de>wrote:

> Hi,
>
> with Felipe's help I've just added the second pull request management
> tool to mange pull requests.
>
> The first one is https://qa.php.net/pulls/ this allows any php.net
> developer to close pull requests on github, without us having to manage
> users on github and adding them to groups and all that stuff. I guess
> most of you have seen that.
>
> The new one is a simple integration of pull requests to the bug tracker.
> Similar to the "patch" feature of the bug tracker it is meant to link
> pull requests from bugs so one can easily use a quick search to find all
> bugs with code waiting for a review and having php.net users assigned to
> pull requests.
>
> Search for recent bugs with patch or pull request:
>
> https://bugs.php.net/search.php?boolean=3D0&limit=3D30&order_by=3Did&dire=
ction=3DDESC&cmd=3Ddisplay&status=3DOpen&bug_age=3D0&bug_updated=3D0&bug_ty=
pe=3DAll&patch=3DY&pull=3DY
> Search for recent bugs with pull requests only:
>
> https://bugs.php.net/search.php?boolean=3D0&limit=3D30&order_by=3Did&dire=
ction=3DDESC&cmd=3Ddisplay&status=3DOpen&bug_age=3D0&bug_updated=3D0&bug_ty=
pe=3DAll&pull=3DY
>
> This is a relatively quick hack with room for improvement, some ideas
> anybody can pick up (I'm happy to give a hand where needed):
>
>  - Add functionality from qa.php.net/pull for closing pull requests
>  - Add a note to github when a bug is assigned to a pull request
>  - Show more details about the pull request
>  - Improve the usability
>  - Improve the code
>  - ...
>
> Happy bug fixing!
>
> johannes
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

Excellent stuff!

I like the idea of having bugs linked to github. Most often I find a great
disconnect between the bugs and github so that idea strikes me as very
convenient since knowing someone is assigned in both places alleviates the
need to go hunting.

--089e0122efde26651d04d59d733e--