Morning!
I was creating a patch to allow serialize/unserialize of the DateTimeZone
object. When running make test I found that we already have a test for
the serialize/unserialize of DateTimeZone. The test checks that we are
not able to serialize/unserialize the DateTimeZone object:
https://github.com/php/php-src/blob/PHP-5.4/ext/date/tests/DateTimeZone_serialize.phpt
Is the test correct or do we want to be able to serialize/unserialize
DateTimeZone? If the test is correct, why do we not want to be able to
serialize/unserialize DateTimeZone objects?
Thank you!
--
Lonny Kapelushnik
http://lonnylot.com
(732) 807-5509
Hi!
object. When running
make testI found that we already have a test for
the serialize/unserialize of DateTimeZone. The test checks that we are
not able to serialize/unserialize the DateTimeZone object:
https://github.com/php/php-src/blob/PHP-5.4/ext/date/tests/DateTimeZone_serialize.phptIs the test correct or do we want to be able to serialize/unserialize
DateTimeZone? If the test is correct, why do we not want to be able to
serialize/unserialize DateTimeZone objects?
We want it to be serializable. This test probably should have been XFAIL
test instead, but in general it's kind of hard to test for code that
doesn't work, so I guess it was instead made to test the current state
of the code.
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227