Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:63238 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 82744 invoked from network); 25 Sep 2012 20:07:56 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Sep 2012 20:07:56 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.203 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.203 smtp203.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.203] ([67.192.241.203:48154] helo=smtp203.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 66/A1-00446-A1F02605 for ; Tue, 25 Sep 2012 16:07:55 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp10.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id 5C27B1B8440; Tue, 25 Sep 2012 16:07:52 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp10.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 7760C1B84D8; Tue, 25 Sep 2012 16:07:51 -0400 (EDT) Message-ID: <50620F16.3080204@sugarcrm.com> Date: Tue, 25 Sep 2012 13:07:50 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: Lonny Kapelushnik CC: PHP Internals , Derick Rethans References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] DateTimeZone Serialize/Unserialize From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > object. When running `make test` I found that we already have a test for > the serialize/unserialize of DateTimeZone. The test checks that we are > _not_ able to serialize/unserialize the DateTimeZone object: > https://github.com/php/php-src/blob/PHP-5.4/ext/date/tests/DateTimeZone_serialize.phpt > > Is the test correct or do we want to be able to serialize/unserialize > DateTimeZone? If the test is correct, why do we not want to be able to > serialize/unserialize DateTimeZone objects? We want it to be serializable. This test probably should have been XFAIL test instead, but in general it's kind of hard to test for code that doesn't work, so I guess it was instead made to test the current state of the code. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227