[PATCH]mysql_pconnect leaks file descriptors on reconnect View as Markdown

Hi:

and the reason for why this cleanup cound not be done in dtor,  is

that in dtor,
it also clean the content, option, which should not free at that memont,

alos IMO, that is not a dtor time in theory(reconnecting with a

same mysql->conn).

thanks

2011/8/22 Laruence laruence@php.net:

georg, andery, ulf:

   hello,  there is a bug in mysqlnd,  the details about this bug can
be found at https://bugs.php.net/bug.php?id=55473

   I found the reason is that mysqlnd_connect didn't free the stream
when doing reconnect.

   I have submitted a patch for  this,  but I am not very sure the
patch is okey.

   could you review this patch?  thanks.

--
Laruence  Xinchen Hui
http://www.laruence.com/

--
Laruence  Xinchen Hui
http://www.laruence.com/

Hi,

georg, andery, ulf:

 hello,  there is a bug in mysqlnd,  the details about this bug can

be found at https://bugs.php.net/bug.php?id=55473

 I found the reason is that mysqlnd_connect didn't free the stream

when doing reconnect.

 I have submitted a patch for  this,  but I am not very sure the

patch is okey.

 could you review this patch?  thanks.

can you resend the patch, name it .txt, anything else doesn't get
through the ML, AFAIK.

Andrey