Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54781
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.42 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <CABBJUpdWbzt9312++Pq42EL3aM2p8=7Hk37VXMLTjTCK+zRRbw@mail.gmail.com>
References: <CABBJUpdWbzt9312++Pq42EL3aM2p8=7Hk37VXMLTjTCK+zRRbw@mail.gmail.com>
Date: Mon, 22 Aug 2011 17:14:09 +0800
Message-ID: <CABBJUpcQqUJUD_0eBjkFeNM9FL=3HEXZNOs50F1__0a1Rv_O+Q@mail.gmail.com>
To: andrey.hristov@oracle.com, georg.richter@oracle.com, ulf.wendel@oracle.com
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH]mysql_pconnect leaks file descriptors on reconnect
From: laruence@php.net (Laruence)

Hi:

    and the reason for why this cleanup cound not be done in dtor,  is
that in dtor,
it also clean the content, option, which should not free at that memont,

    alos IMO, that is not a dtor time in theory(reconnecting with a
same mysql->conn).

thanks

2011/8/22 Laruence <laruence@php.net>:
> georg, andery, ulf:
>
> =C2=A0 =C2=A0hello, =C2=A0there is a bug in mysqlnd, =C2=A0the details ab=
out this bug can
> be found at https://bugs.php.net/bug.php?id=3D55473
>
> =C2=A0 =C2=A0I found the reason is that mysqlnd_connect didn't free the s=
tream
> when doing reconnect.
>
> =C2=A0 =C2=A0I have submitted a patch for =C2=A0this, =C2=A0but I am not =
very sure the
> patch is okey.
>
> =C2=A0 =C2=A0could you review this patch? =C2=A0thanks.
>
> --
> Laruence =C2=A0Xinchen Hui
> http://www.laruence.com/
>



--=20
Laruence =C2=A0Xinchen Hui
http://www.laruence.com/