Hi!
In order to fix Xdebug bug #587 (http://bugs.xdebug.org/view.php?id=587)
I need to have access to module_initialized which is currently a static
in main/main.c. I've added a simple function to retrieve that and would
like to commit that to 5.3/5.4 and trunk. Comments?
The patch is attached.
cheers,
Derick
--
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug
Hi!
Hi!
In order to fix Xdebug bug #587 (http://bugs.xdebug.org/view.php?id=587)
I need to have access to module_initialized which is currently a static
in main/main.c. I've added a simple function to retrieve that and would
like to commit that to 5.3/5.4 and trunk. Comments?
The patch is attached.
Doesn't seem to do any harm, though adding it in 5.3 would mean that
some xdebug builds would work only with 5.3.7 but not 5.3.6, unless you
do some magic. For 5.4, I think it's fine.
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
In order to fix Xdebug bug #587
(http://bugs.xdebug.org/view.php?id=587) I need to have access to
module_initialized which is currently a static in main/main.c. I've
added a simple function to retrieve that and would like to commit
that to 5.3/5.4 and trunk. Comments? The patch is attached.Doesn't seem to do any harm, though adding it in 5.3 would mean that
some xdebug builds would work only with 5.3.7 but not 5.3.6, unless
you do some magic. For 5.4, I think it's fine.
Makes sense, committed to 5.4 and trunk.
Derick
Hi!
In order to fix Xdebug bug #587 (http://bugs.xdebug.org/view.php?id=587)
I need to have access to module_initialized which is currently a static
in main/main.c. I've added a simple function to retrieve that and would
like to commit that to 5.3/5.4 and trunk. Comments?
The patch is attached.
I know the variable uses singular, but maybe
php_get_modules_initialized() is clearer?
johannes
In order to fix Xdebug bug #587
(http://bugs.xdebug.org/view.php?id=587) I need to have access to
module_initialized which is currently a static in main/main.c. I've
added a simple function to retrieve that and would like to commit
that to 5.3/5.4 and trunk. Comments? The patch is attached.I know the variable uses singular, but maybe
php_get_modules_initialized() is clearer?
But afaik, it means PHP as "module", so plural makes little sense to me?
cheers,
Derick
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug
2011/6/24 Derick Rethans derick@php.net:
In order to fix Xdebug bug #587
(http://bugs.xdebug.org/view.php?id=587) I need to have access to
module_initialized which is currently a static in main/main.c. I've
added a simple function to retrieve that and would like to commit
that to 5.3/5.4 and trunk. Comments? The patch is attached.I know the variable uses singular, but maybe
php_get_modules_initialized() is clearer?But afaik, it means PHP as "module", so plural makes little sense to me?
It is more about the SAPI than SAPI only available as module. I would
add sapi in the function as well to avoid any confusion.
php_sapi_get_module_initialized.
Cheers,
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org
Hi Derick,
I don't see any problems committing it.
Thanks. Dmitry.
Hi!
In order to fix Xdebug bug #587 (http://bugs.xdebug.org/view.php?id=587)
I need to have access to module_initialized which is currently a static
in main/main.c. I've added a simple function to retrieve that and would
like to commit that to 5.3/5.4 and trunk. Comments?
The patch is attached.cheers,
Derick