Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53581
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=vK3joaDn106EBmPQuYHmJIYCOeCeQ2jqgRkSeK8zzGHYO/tjZapVCxKXcwi5xCsnkO
         PPOk9SYOUUq26I0gcbdIjoSWwnw/Fc4ZRrEWql5VV78Q608vFF25J9PjisLJTFAlib5Y
         DCSdyQmP/kgNfWBOaGiDiSDqpKc97rl0APL+c=
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1106241809270.3774@whisky>
References: <alpine.DEB.2.02.1106232142180.3774@whisky>
	<1308918416.2279.1.camel@guybrush>
	<alpine.DEB.2.02.1106241809270.3774@whisky>
Date: Sat, 25 Jun 2011 11:01:32 +0200
Message-ID: <BANLkTin8Vcz9D+HHUCqaGkf5SMjbZOkSyw@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: =?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@schlueters.de>, 
	PHP Developers Mailing List <internals@lists.php.net>, dmitry@zend.com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Small PHPAPI addition
From: pierre.php@gmail.com (Pierre Joye)

2011/6/24 Derick Rethans <derick@php.net>:
> On Fri, 24 Jun 2011, Johannes Schl=FCter wrote:
>
>> On Thu, 2011-06-23 at 21:47 +0100, Derick Rethans wrote:
>> >
>> > In order to fix Xdebug bug #587
>> > (http://bugs.xdebug.org/view.php?id=3D587) I need to have access to
>> > module_initialized which is currently a static in main/main.c. I've
>> > added a simple function to retrieve that and would like to commit
>> > that to 5.3/5.4 and trunk. Comments? The patch is attached.
>>
>> I know the variable uses singular, but maybe
>> php_get_modules_initialized() is clearer?
>
> But afaik, it means PHP as "module", so plural makes little sense to me?

It is more about the SAPI than SAPI only available as module. I would
add sapi in the function as well to avoid any confusion.
php_sapi_get_module_initialized.

Cheers,
--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org