Anybody have a problem with me committing the patch below?

We still use 2.9.5 for our FreeBSD builds (ya, I know its old) and
while building extensions we get:

Zend/zend.h:379: warning: always_inline' attribute directive ignored Zend/zend.h:383: warning:always_inline' attribute directive ignored
Zend/zend.h:387: warning: always_inline' attribute directive ignored Zend/zend.h:391: warning:always_inline' attribute directive ignored
Zend/zend.h:395: warning: always_inline' attribute directive ignored Zend/zend.h:399: warning:always_inline' attribute directive ignored
Zend/zend.h:403: warning: always_inline' attribute directive ignored Zend/zend.h:407: warning:always_inline' attribute directive ignored

Adding the patch removes the warning.

Brian

Index: Zend/zend.h

RCS file: /repository/ZendEngine2/zend.h,v
retrieving revision 1.293.2.11.2.9.2.33
diff -u -p -r1.293.2.11.2.9.2.33 zend.h
--- Zend/zend.h 18 Mar 2009 01:08:12 -0000 1.293.2.11.2.9.2.33
+++ Zend/zend.h 29 Apr 2009 14:16:28 -0000
@@ -361,7 +361,11 @@ struct _zval_struct {
#define Z_SET_ISREF_TO(z, isref) Z_SET_ISREF_TO_P(&(z), isref)

#if defined(GNUC)
+#if GNUC >= 3
#define zend_always_inline inline attribute((always_inline))
+#else
+#define zend_always_inline inline
+#endif
#elif defined(_MSC_VER)
#define zend_always_inline __forceinline
#else