Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43802 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 55861 invoked from network); 29 Apr 2009 14:21:24 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 Apr 2009 14:21:24 -0000 Authentication-Results: pb1.pair.com header.from=list@firehawksystems.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=list@firehawksystems.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain firehawksystems.com from 208.83.223.140 cause and error) X-PHP-List-Original-Sender: list@firehawksystems.com X-Host-Fingerprint: 208.83.223.140 ls6.firehawksystems.com Received: from [208.83.223.140] ([208.83.223.140:60548] helo=ls6.firehawksystems.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2B/AA-21632-26268F94 for ; Wed, 29 Apr 2009 10:21:23 -0400 Received: from albook-wireless.brianfrance.com (adsl-68-78-3-97.dsl.ipltin.ameritech.net [68.78.3.97]) (authenticated bits=0) by ls6.firehawksystems.com (8.14.3/8.14.3) with ESMTP id n3TELHUg025928 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Wed, 29 Apr 2009 07:21:19 -0700 (PDT) Message-ID: <6521477F-B5AC-40B4-AB4A-3E614CA6AA2F@firehawksystems.com> To: PHP internals Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Date: Wed, 29 Apr 2009 10:21:16 -0400 Cc: mls@pooteeweet.org X-Mailer: Apple Mail (2.930.3) X-Virus-Scanned: clamav-milter 0.95.1 at ls6.firehawksystems.com X-Virus-Status: Clean Subject: PHP 5.3 build patch From: list@firehawksystems.com ("Brian J. France") Anybody have a problem with me committing the patch below? We still use 2.9.5 for our FreeBSD builds (ya, I know its old) and while building extensions we get: Zend/zend.h:379: warning: `always_inline' attribute directive ignored Zend/zend.h:383: warning: `always_inline' attribute directive ignored Zend/zend.h:387: warning: `always_inline' attribute directive ignored Zend/zend.h:391: warning: `always_inline' attribute directive ignored Zend/zend.h:395: warning: `always_inline' attribute directive ignored Zend/zend.h:399: warning: `always_inline' attribute directive ignored Zend/zend.h:403: warning: `always_inline' attribute directive ignored Zend/zend.h:407: warning: `always_inline' attribute directive ignored Adding the patch removes the warning. Brian Index: Zend/zend.h =================================================================== RCS file: /repository/ZendEngine2/zend.h,v retrieving revision 1.293.2.11.2.9.2.33 diff -u -p -r1.293.2.11.2.9.2.33 zend.h --- Zend/zend.h 18 Mar 2009 01:08:12 -0000 1.293.2.11.2.9.2.33 +++ Zend/zend.h 29 Apr 2009 14:16:28 -0000 @@ -361,7 +361,11 @@ struct _zval_struct { #define Z_SET_ISREF_TO(z, isref) Z_SET_ISREF_TO_P(&(z), isref) #if defined(__GNUC__) +#if __GNUC__ >= 3 #define zend_always_inline inline __attribute__((always_inline)) +#else +#define zend_always_inline inline +#endif #elif defined(_MSC_VER) #define zend_always_inline __forceinline #else