phar update

Em Sex, 2009-02-20 às 21:36 -0600, Greg Beaver escreveu:

Hi,

As PHP has the good fortune of being blessed with Scott MacVicar who
connected me with the ppc64 test machine provided by IBM and the sparc
machine provided by Sun through David Soria-Parra (thank you thank you
thank you), phar has now been verified as working in the following
configurations that were previously untested:

64-bit, big-endian, gcc linux
64-bit, big-endian, suncc SunOS

This means phar has been verified as working by me on the following
configurations:

32-bit, little-endian, gcc linux
64-bit, little-endian, gcc Darwin OS X
32-bit, little-endian, MS Windows XP
64-bit, little-endian, gcc linux
64-bit, big-endian, gcc linux
64-bit, big-endian, suncc, SunOS

When I say working, I mean 100% of non-skipped tests passing, no compile
warnings. The tests exert 80% code coverage, mostly leaving untestable
stuff like errors that are only likely to occur when the disk crashes.

Great work! :D

--
Regards,
Felipe Pena

Hello Greg,

in one word: Awesome!

Saturday, February 21, 2009, 4:36:38 AM, you wrote:

Hi,

As PHP has the good fortune of being blessed with Scott MacVicar who
connected me with the ppc64 test machine provided by IBM and the sparc
machine provided by Sun through David Soria-Parra (thank you thank you
thank you), phar has now been verified as working in the following
configurations that were previously untested:

64-bit, big-endian, gcc linux
64-bit, big-endian, suncc SunOS

This means phar has been verified as working by me on the following
configurations:

32-bit, little-endian, gcc linux
64-bit, little-endian, gcc Darwin OS X
32-bit, little-endian, MS Windows XP
64-bit, little-endian, gcc linux
64-bit, big-endian, gcc linux
64-bit, big-endian, suncc, SunOS

When I say working, I mean 100% of non-skipped tests passing, no compile
warnings. The tests exert 80% code coverage, mostly leaving untestable
stuff like errors that are only likely to occur when the disk crashes.

In addition, I discovered potential problems with the zip
implementation, in that the code originally used a packed struct, taking
advantage of #pragma pack on windows and sgi, __attribute for gcc.
However, it did not work with sun's cc, and on further reading, I
discovered that using a packed struct without specific compiler flags
could lead to bus errors on sparc machines, and to page faults on
windows 64-bit. The specific compiler flags to fix this would result in
a slower PHP, which was unacceptable.

Thus, I undertook a refactoring of the way zip's structs are accessed,
taking advantage of the fact that structs of char arrays are never
padded, and use some simple math to convert char[4] to php_uint32 and
char[2] to php_uint16. The code is much simpler, works without #ifdef
on both big-endian and little-endian systems, and has no risk of failing
with any future compilers or OSes as it doesn't rely on
compiler-specific processing commands.

To be clear: this issue did not affect tar-based phars, or phar-based
phars, and only affected zip-based phars on SunOS with sun CC, or on any
Sparc machine or Windows 64-bit if and only if the specific zip file
would cause a read across a word boundary (whew). And also to be clear:
this problem is ancient history now.

I do need some help verifying phar as working with the following
configurations:

any endian any unix with intel CC
any Windows Vista
64-bit Windows XP
any other supported OS/compiler/processor combo I didn't list.

Verification is as simple as compiling PHP 5.3 from CVS or snap and
running the tests.

Also thanks to those raising concerns about phar, it has served to make
it stronger.

Thanks,
Greg

Best regards,
Marcus

When I say working, I mean 100% of non-skipped tests passing, no compile
warnings. The tests exert 80% code coverage, mostly leaving untestable
stuff like errors that are only likely to occur when the disk crashes.

Seriously well done! Kudos

--
Slan,
David

Hi Greg

2009/2/21 Greg Beaver greg@chiaraquartet.net:

Hi,

[snip]

Good work!

I do need some help verifying phar as working with the following
configurations:

any endian any unix with intel CC
any Windows Vista
64-bit Windows XP
any other supported OS/compiler/processor combo I didn't list.

I tested phar under 5.3-cvs and HEAD with Windows Vista 32bit little
endian and VC9.

Theres only one compilation warning which only exists in HEAD:
ext\phar\func_interceptors.c(101) : warning C4101: 'newlen' :
unreferenced local variable

However tests wise then the following tests fails in 5.3-cvs:
Phar front controller with mounted external file
[C:\php\src\ext\phar\tests\front.phar.phpt]
Phar::getSupportedSignatures()
[C:\php\src\ext\phar\tests\phar_get_supported_signatures_002.phpt]
Phar::setStub() (zip-based) [C:\php\src\ext\phar\tests\zip\phar_stub.phpt]

and in 124 tests fails for in HEAD, instead of writing an insanely
long list here, I have zipped both the test log and diffs for 5.3 and
HEAD which can be downloaded here:

Verification is as simple as compiling PHP 5.3 from CVS or snap and
running the tests.

Also thanks to those raising concerns about phar, it has served to make
it stronger.

Thanks,
Greg

--

--
Kalle Sommer Nielsen
kalle@php.net

Hello Greg,

I have an AIX PPC 64 bits, IBM XL C/C++ compiler, which I can run the
tests. Is it of any interest ?

I read you tested on a PPC 64 already but as far as i understand you
used a GNU compiler.

Regards,
Igor Feghali.

While trying to perform phar testing on the system previously
mentioned by me, I couldn't manage to get php5.3-200902261130 to
compile with IBM CC. First 3 lines of error:

"/tmp/php5.3-200902261130/ext/pcre/pcrelib/pcre_internal.h", line
976.3: 1506-046 (S) Syntax error.
"/tmp/php5.3-200902261130/ext/pcre/pcrelib/pcre_internal.h", line
1027.3: 1506-046 (S) Syntax error.
"/tmp/php5.3-200902261130/ext/pcre/pcrelib/pcre_internal.h", line
1137.8: 1506-166 (S) Definition of function BOOL requires parentheses.

It seems that BOOL isn't getting defined. Can someone please help me ?

Thank you.