Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43217
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.180 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=x4hIqxeehE5w+pic1/kqmJOmpq7UAIOQ/QVdUZSE1qPJF6UT37ReslTmZmBV9SazSZ
         9CU0aApGIwmfKZ9Tv5g1bnxRCMkbPmV4xh5vIOS9Pqm47kIDGtouWWYZnPCwy9xPYA5B
         3R3tlT/80ENuer13TNVzRXlRpYjUoAUzESGxo=
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <49AA022B.1040701@chiaraquartet.net>
References: <499F76C6.4010601@chiaraquartet.net>
	 <2dedb8a0902210755g1b6268f8p34058d23203e0631@mail.gmail.com>
	 <49AA022B.1040701@chiaraquartet.net>
Date: Sun, 1 Mar 2009 06:20:24 +0100
Message-ID: <2dedb8a0902282120n42fcf625ge8ccc7d82fb7e23d@mail.gmail.com>
To: Greg Beaver <greg@chiaraquartet.net>
Cc: PHP Developers Mailing List <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] phar update
From: kalle@php.net (Kalle Sommer Nielsen)

Hi Greg

2009/3/1 Greg Beaver <greg@chiaraquartet.net>:
> hi Kalle,
>
> Thank you very much for your work on this, it is much appreciated.
> Sorry for the delay in replying, I have been out of town for a while.

No problem :)

>
> Kalle Sommer Nielsen wrote:
>> Hi Greg
>>
>> 2009/2/21 Greg Beaver <greg@chiaraquartet.net>:
>>> Hi,
>>>
>>> [snip]
>>
>> Good work!
>>
>>> I do need some help verifying phar as working with the following
>>> configurations:
>>>
>>> any endian any unix with intel CC
>>> any Windows Vista
>>> 64-bit Windows XP
>>> any other supported OS/compiler/processor combo I didn't list.
>>
>> I tested phar under 5.3-cvs and HEAD with Windows Vista 32bit little
>> endian and VC9.
>>
>> Theres only one compilation warning which only exists in HEAD:
>> ext\phar\func_interceptors.c(101) : warning C4101: 'newlen' :
>> unreferenced local variable
>>
>> However tests wise then the following tests fails in 5.3-cvs:
>> Phar front controller with mounted external file
>> [C:\php\src\ext\phar\tests\front.phar.phpt]
>
> It appears that this test is not line-ending agnostic, and I'm about to
> commit a fix, as the problem is simply the length of the string is 172
> instead of 167 due to extra \r. =A0This is very good news :)
>
>> Phar::getSupportedSignatures()
>> [C:\php\src\ext\phar\tests\phar_get_supported_signatures_002.phpt]
>
> This one is perplexing - I wonder if you have built ext/hash statically
> or as a .dll? =A0The phar ext is not detected ext/hash, but the test is
> not skipping because ext/hash is present in the SKIPIF

ext/hash was built staticlly (default)

I looked into the issue and it seems like PHAR_HASH_OK isn't getting
defined, so I assume its a missing AC_DEFINE call in config.w32, so
something along the lines of the following should do if ext/hash is
built staticlly:

if(PHP_HASH !=3D "no" && !PHP_HASH_SHARED) {
	AC_DEFINE("PHAR_HASH_OK", 1);
}

using the above code in config.w32 and then buildconf, configure,
nmake and run-tests on that test makes it pass but the test will still
fail if ext/hash is built as shared ofcourse.

>
>> Phar::setStub() (zip-based) [C:\php\src\ext\phar\tests\zip\phar_stub.php=
t]
>
> This one is actually troubling, as it looks like a crash is terminating
> the test at the second setStub()

I did some more tests and a couple of fresh checkouts and builds and
this test does not fail anymore for me, if anyone can confirm it would
be good.

>
> I will try to investigate, but if others can confirm this failure on
> their windows, that would be helpful.
>
> Thanks,
> Greg
>



--=20
Kalle Sommer Nielsen
kalle@php.net