5.3+ build broken, see compile log View as Markdown

Pierre Joye wrote:

Hi,

A commit in the last 24 hours breaks the builds:

d:\php-sdk\snap_5_3\vc9\x86\snap53_vc9\zend\zend_vm_execute.h(2735) :
error C2036: 'void *' : unknown size
d:\php-sdk\snap_5_3\vc9\x86\snap53_vc9\zend\zend_vm_execute.h(10445) :
error C2036: 'void *' : unknown size
d:\php-sdk\snap_5_3\vc9\x86\snap53_vc9\zend\zend_vm_execute.h(17792) :
error C2036: 'void *' : unknown size

Hi,

Unrelated to this windows compilation problem (thanks Felipe for the
quick fix), I'm concerned to see that I missed an example of opcode
modification. We can't modify opcodes directly because of opcode
caches. This code needs to be refactored slightly to either create the
needed stuff in compile-time and pass it in with ZEND_OP_DATA or one of
the unused op1/op2 (best) or run-time estrndup finagling (not so good).

Thanks for pointing this out Pierre.

Greg