Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:41685
Return-Path: <greg@chiaraquartet.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 92726 invoked from network); 5 Nov 2008 15:30:40 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 5 Nov 2008 15:30:40 -0000
Authentication-Results: pb1.pair.com header.from=greg@chiaraquartet.net; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=greg@chiaraquartet.net; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain chiaraquartet.net from 74.125.44.28 cause and error)
X-PHP-List-Original-Sender: greg@chiaraquartet.net
X-Host-Fingerprint: 74.125.44.28 yx-out-2324.google.com  
Received: from [74.125.44.28] ([74.125.44.28:60795] helo=yx-out-2324.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 08/A0-22938-E1CB1194 for <internals@lists.php.net>; Wed, 05 Nov 2008 10:30:39 -0500
Received: by yx-out-2324.google.com with SMTP id 3so17953yxj.83
        for <internals@lists.php.net>; Wed, 05 Nov 2008 07:30:36 -0800 (PST)
Received: by 10.65.23.5 with SMTP id a5mr832278qbj.30.1225899034635;
        Wed, 05 Nov 2008 07:30:34 -0800 (PST)
Received: from ?192.168.0.106? ([76.84.4.101])
        by mx.google.com with ESMTPS id p9sm25255569qbp.15.2008.11.05.07.30.32
        (version=TLSv1/SSLv3 cipher=RC4-MD5);
        Wed, 05 Nov 2008 07:30:33 -0800 (PST)
Message-ID: <4911BC22.6050506@chiaraquartet.net>
Date: Wed, 05 Nov 2008 09:30:42 -0600
User-Agent: Thunderbird 2.0.0.17 (X11/20080925)
MIME-Version: 1.0
To: Pierre Joye <pierre.php@gmail.com>
CC: PHP internals <internals@lists.php.net>, 
 Marcus Boerger <helly@php.net>,
 =?ISO-8859-1?Q?Johannes_Schl=FCter?= <Johannes.Schlueter@sun.com>, 
 Dmitry Stogov <dmitry@zend.com>
References: <fe05d1540811050231i72c3fa3dp56513ebdd9d042dc@mail.gmail.com>
In-Reply-To: <fe05d1540811050231i72c3fa3dp56513ebdd9d042dc@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: 5.3+ build broken, see compile log
From: greg@chiaraquartet.net (Gregory Beaver)

Pierre Joye wrote:
> Hi,
> 
> A commit in the last 24 hours breaks the builds:
> 
> d:\php-sdk\snap_5_3\vc9\x86\snap53_vc9\zend\zend_vm_execute.h(2735) :
> error C2036: 'void *' : unknown size
> d:\php-sdk\snap_5_3\vc9\x86\snap53_vc9\zend\zend_vm_execute.h(10445) :
> error C2036: 'void *' : unknown size
> d:\php-sdk\snap_5_3\vc9\x86\snap53_vc9\zend\zend_vm_execute.h(17792) :
> error C2036: 'void *' : unknown size

Hi,

Unrelated to this windows compilation problem (thanks Felipe for the
quick fix), I'm concerned to see that I missed an example of opcode
modification.  We can't modify opcodes directly because of opcode
caches.  This code needs to be refactored slightly to either create the
needed stuff in compile-time and pass it in with ZEND_OP_DATA or one of
the unused op1/op2 (best) or run-time estrndup finagling (not so good).

Thanks for pointing this out Pierre.

Greg