There is a bug in stream_filter_remove() that calls the stream destructor
when it shouldn't. I have included two attachments--one is the patch to
streamsfuncs.c and the other is a test.
Take a look :)
Ilia
hi Ilia!
On Mon, Sep 29, 2008 at 12:48 AM, Ilia Cheishvili
ilia.cheishvili@gmail.com wrote:
There is a bug in
stream_filter_remove()that calls the stream destructor
when it shouldn't. I have included two attachments--one is the patch to
streamsfuncs.c and the other is a test.Take a look :)
Wrong bug #, can you post the right # please? It would help to have
the patch (link) in the bug report as well :)
Thanks for your work!
Cheers,
Sorry for that! I transposed two characters. The right bug # is 46164.
I'll add the patch to the bug as well.
Ilia
hi Ilia!
On Mon, Sep 29, 2008 at 12:48 AM, Ilia Cheishvili
ilia.cheishvili@gmail.com wrote:There is a bug in
stream_filter_remove()that calls the stream destructor
when it shouldn't. I have included two attachments--one is the patch to
streamsfuncs.c and the other is a test.Take a look :)
Wrong bug #, can you post the right # please? It would help to have
the patch (link) in the bug report as well :)Thanks for your work!
Cheers,
On Mon, Sep 29, 2008 at 12:57 AM, Ilia Cheishvili
ilia.cheishvili@gmail.com wrote:
Sorry for that! I transposed two characters. The right bug # is 46164.
I'll add the patch to the bug as well.
Can you do it as well for your other patches please?
Cheers,
No problem, I'm do that right now. I'll follow this process in the future,
too :)
Thanks Pierre!
Ilia
On Mon, Sep 29, 2008 at 12:57 AM, Ilia Cheishvili
ilia.cheishvili@gmail.com wrote:Sorry for that! I transposed two characters. The right bug # is 46164.
I'll add the patch to the bug as well.Can you do it as well for your other patches please?
Cheers,
What did we decide to do about this patch? I noticed that it never got any
feedback about the actual patch. Could someone take a look?
Thanks!
Ilia
On Sun, Sep 28, 2008 at 4:48 PM, Ilia Cheishvili
ilia.cheishvili@gmail.comwrote:
There is a bug in
stream_filter_remove()that calls the stream destructor
when it shouldn't. I have included two attachments--one is the patch to
streamsfuncs.c and the other is a test.Take a look :)
Ilia
Hi Ilia
2008/10/8 Ilia Cheishvili ilia.cheishvili@gmail.com:
What did we decide to do about this patch? I noticed that it never got any
feedback about the actual patch. Could someone take a look?
Thanks!
This bug was fixed 5 days ago by Arnaud, which abit different patch:
http://news.php.net/php.cvs/53362
Ilia
On Sun, Sep 28, 2008 at 4:48 PM, Ilia Cheishvili
ilia.cheishvili@gmail.comwrote:There is a bug in
stream_filter_remove()that calls the stream destructor
when it shouldn't. I have included two attachments--one is the patch to
streamsfuncs.c and the other is a test.Take a look :)
Ilia
--
Kalle Sommer Nielsen