# [PATCH] Fix bug #46146 - Thread: https://externals.io/message/40746 - Original archive: https://news-web.php.net/php.internals/40746 - Started by Ilia Cheishvili on 2008-09-28T22:48:01+00:00 - Messages: 7 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #40746 — Ilia Cheishvili — 2008-09-28T22:48:01+00:00 URL: https://externals.io/message/40746#40746 There is a bug in `stream_filter_remove()` that calls the stream destructor when it shouldn't. I have included two attachments--one is the patch to streamsfuncs.c and the other is a test. Take a look :) Ilia --- ## #40747 — Pierre Joye — 2008-09-28T22:54:30+00:00 URL: https://externals.io/message/40746#40747 · In reply to: #40746 hi Ilia! On Mon, Sep 29, 2008 at 12:48 AM, Ilia Cheishvili wrote: > There is a bug in `stream_filter_remove()` that calls the stream destructor > when it shouldn't. I have included two attachments--one is the patch to > streamsfuncs.c and the other is a test. > > Take a look :) Wrong bug #, can you post the right # please? It would help to have the patch (link) in the bug report as well :) Thanks for your work! Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org --- ## #40748 — Ilia Cheishvili — 2008-09-28T22:57:51+00:00 URL: https://externals.io/message/40746#40748 · In reply to: #40747 Sorry for that! I transposed two characters. The right bug # is 46164. I'll add the patch to the bug as well. Ilia > hi Ilia! > > On Mon, Sep 29, 2008 at 12:48 AM, Ilia Cheishvili > wrote: > > […] > > Wrong bug #, can you post the right # please? It would help to have > the patch (link) in the bug report as well :) > > Thanks for your work! > > Cheers, > -- > Pierre > http://blog.thepimp.net | http://www.libgd.org --- ## #40749 — Pierre Joye — 2008-09-28T22:58:33+00:00 URL: https://externals.io/message/40746#40749 · In reply to: #40748 On Mon, Sep 29, 2008 at 12:57 AM, Ilia Cheishvili wrote: > Sorry for that! I transposed two characters. The right bug # is 46164. > I'll add the patch to the bug as well. Can you do it as well for your other patches please? Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org --- ## #40750 — Ilia Cheishvili — 2008-09-28T23:01:02+00:00 URL: https://externals.io/message/40746#40750 · In reply to: #40749 No problem, I'm do that right now. I'll follow this process in the future, too :) Thanks Pierre! Ilia > On Mon, Sep 29, 2008 at 12:57 AM, Ilia Cheishvili > wrote: > > […] > > Can you do it as well for your other patches please? > > Cheers, > -- > Pierre > http://blog.thepimp.net | http://www.libgd.org --- ## #40882 — Ilia Cheishvili — 2008-10-08T20:38:13+00:00 URL: https://externals.io/message/40746#40882 · In reply to: #40746 What did we decide to do about this patch? I noticed that it never got any feedback about the actual patch. Could someone take a look? Thanks! Ilia On Sun, Sep 28, 2008 at 4:48 PM, Ilia Cheishvili wrote: > There is a bug in `stream_filter_remove()` that calls the stream destructor > when it shouldn't. I have included two attachments--one is the patch to > streamsfuncs.c and the other is a test. > > Take a look :) > > Ilia --- ## #40884 — Kalle Sommer Nielsen — 2008-10-09T09:08:00+00:00 URL: https://externals.io/message/40746#40884 · In reply to: #40882 Hi Ilia 2008/10/8 Ilia Cheishvili : > What did we decide to do about this patch? I noticed that it never got any > feedback about the actual patch. Could someone take a look? > Thanks! This bug was fixed 5 days ago by Arnaud, which abit different patch: http://news.php.net/php.cvs/53362 > > Ilia > > On Sun, Sep 28, 2008 at 4:48 PM, Ilia Cheishvili > wrote: > > > […] > -- Kalle Sommer Nielsen