Hi,
I would like to contribute to ext/pgsql module. Could I have CVS
account?
I've been working on PostgreSQL development for years. My intention
is to catch up PostgreSQL develpment especially when new API is
added. For example an API added to PostgreSQL 8.1 (back to 2005) is
not in PHP yet.
I have talked to Yasuo Ohgaki (one of the pgsql module maintainers)
and he seems to be happy.
Tatsuo Ishii
SRA OSS, Inc. Japan
Hello Tatsuo,
first of all thanks for offering to help!
the usual way is to provide a few patches. You can check
http://bugs.php.net for open bugs in your area. When we like the patches
we'll apply them and give you an account.
marcus
Monday, April 14, 2008, 1:21:47 PM, you wrote:
Hi,
I would like to contribute to ext/pgsql module. Could I have CVS
account?
I've been working on PostgreSQL development for years. My intention
is to catch up PostgreSQL develpment especially when new API is
added. For example an API added to PostgreSQL 8.1 (back to 2005) is
not in PHP yet.
I have talked to Yasuo Ohgaki (one of the pgsql module maintainers)
and he seems to be happy.Tatsuo Ishii
SRA OSS, Inc. Japan
Best regards,
Marcus
Hello Marcus,
Thanks for guiding me. I'm going to make patches in a few days.
BTW, the problem I'm talking about does not seem to exist in the bug
database.
Tatsuo Ishii
SRA OSS, Inc. Japan
Hello Tatsuo,
first of all thanks for offering to help!
the usual way is to provide a few patches. You can check
http://bugs.php.net for open bugs in your area. When we like the patches
we'll apply them and give you an account.marcus
Monday, April 14, 2008, 1:21:47 PM, you wrote:
Hi,
I would like to contribute to ext/pgsql module. Could I have CVS
account?I've been working on PostgreSQL development for years. My intention
is to catch up PostgreSQL develpment especially when new API is
added. For example an API added to PostgreSQL 8.1 (back to 2005) is
not in PHP yet.I have talked to Yasuo Ohgaki (one of the pgsql module maintainers)
and he seems to be happy.Tatsuo Ishii
SRA OSS, Inc. JapanBest regards,
Marcus
Thanks for guiding me. I'm going to make patches in a few days.
BTW, the problem I'm talking about does not seem to exist in the bug
database.
Then open a new ticket - that's what the bug tracker is for. :-)
johannes
Here are the patches against 5.2 HEAD.
Modified API's are:
-
pg_lo_create now accepts an optional parameter (large object
id). This corresponds to lo_create() which is new in PostgreSQL 8.1. -
new API: pg_lo_import_with_oid. Same as pg_lo_import except that it
accepts large object id. This corresponds to lo_import_with_oid()
which is new in PostgreSQL 8.4 (current).
--
Tatsuo Ishii
SRA OSS, Inc. Japan
Hello Marcus,
Thanks for guiding me. I'm going to make patches in a few days.
BTW, the problem I'm talking about does not seem to exist in the bug
database.Tatsuo Ishii
SRA OSS, Inc. JapanHello Tatsuo,
first of all thanks for offering to help!
the usual way is to provide a few patches. You can check
http://bugs.php.net for open bugs in your area. When we like the patches
we'll apply them and give you an account.marcus
Monday, April 14, 2008, 1:21:47 PM, you wrote:
Hi,
I would like to contribute to ext/pgsql module. Could I have CVS
account?I've been working on PostgreSQL development for years. My intention
is to catch up PostgreSQL develpment especially when new API is
added. For example an API added to PostgreSQL 8.1 (back to 2005) is
not in PHP yet.I have talked to Yasuo Ohgaki (one of the pgsql module maintainers)
and he seems to be happy.Tatsuo Ishii
SRA OSS, Inc. JapanBest regards,
Marcus
Here are the patches against 5.2 HEAD.
First of all, please use diff -u
, not just diff
- unified diffs are much more readable.
Modified API's are:
pg_lo_create now accepts an optional parameter (large object
id). This corresponds to lo_create() which is new in PostgreSQL 8.1.new API: pg_lo_import_with_oid. Same as pg_lo_import except that it
accepts large object id. This corresponds to lo_import_with_oid()
which is new in PostgreSQL 8.4 (current).
Is there a real need for a new function?
Can't we modify pg_lo_import() to accept one more argument?
--
Wbr,
Antony Dovgal