Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:37195 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 71670 invoked from network); 23 Apr 2008 07:43:44 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Apr 2008 07:43:44 -0000 Authentication-Results: pb1.pair.com header.from=tony@daylessday.org; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=tony@daylessday.org; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain daylessday.org designates 89.208.40.236 as permitted sender) X-PHP-List-Original-Sender: tony@daylessday.org X-Host-Fingerprint: 89.208.40.236 mail.daylessday.org Linux 2.6 Received: from [89.208.40.236] ([89.208.40.236:59002] helo=daylessday.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id FE/EC-09668-0B8EE084 for ; Wed, 23 Apr 2008 03:43:44 -0400 Received: from [192.168.3.91] (unknown [212.42.62.198]) by daylessday.org (Postfix) with ESMTP id 60F716400F2; Wed, 23 Apr 2008 11:43:41 +0400 (MSD) Message-ID: <480EE8A9.1030102@daylessday.org> Date: Wed, 23 Apr 2008 11:43:37 +0400 User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Tatsuo Ishii CC: helly@php.net, internals@lists.php.net References: <20080414.202147.133891843.t-ishii@sraoss.co.jp> <1167485796.20080415123934@marcus-boerger.de> <20080415.215110.13575073.t-ishii@sraoss.co.jp> <20080417.235013.32148218.t-ishii@sraoss.co.jp> In-Reply-To: <20080417.235013.32148218.t-ishii@sraoss.co.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] CVS Account Request From: tony@daylessday.org (Antony Dovgal) On 17.04.2008 18:50, Tatsuo Ishii wrote: > Here are the patches against 5.2 HEAD. First of all, please use `diff -u`, not just `diff` - unified diffs are much more readable. > Modified API's are: > > 1) pg_lo_create now accepts an optional parameter (large object > id). This corresponds to lo_create() which is new in PostgreSQL 8.1. > > 2) new API: pg_lo_import_with_oid. Same as pg_lo_import except that it > accepts large object id. This corresponds to lo_import_with_oid() > which is new in PostgreSQL 8.4 (current). Is there a real need for a new function? Can't we modify pg_lo_import() to accept one more argument? -- Wbr, Antony Dovgal