Patch for opcode caches

18 years ago by Dmitry Stogov — view source — reply

unread

Hi Marcus,

-----Original Message-----
From: Marcus Boerger [mailto:helly@php.net]
Sent: Thursday, March 13, 2008 9:27 PM
To: Dmitry Stogov
Cc: Andi Gutmans; Stas Malyshev; phpxcache; internals@lists.php.net
Subject: Re: [PHP-DEV] Patch for opcode caches

Hello Dmitry,

Monday, March 10, 2008, 1:48:05 PM, you wrote:

Hi Marcus,

-----Original Message-----
From: Marcus Boerger [mailto:helly@php.net]
Sent: Sunday, March 09, 2008 3:00 PM
To: Dmitry Stogov
Cc: Derick Rethans; internals Mailing List; Andi Gutmans; Stas
Malyshev; phpxcache
Subject: Re: [PHP-DEV] Patch for opcode caches

Hello Dmitry,

please don't apply. The patch looks rather rough and
untested (see
below).

It was tested at least with Zend products and xcache.

Good, I am just worried that we introduce different behavior.
We should just have one execution mode. Your change is better
now having a more detailed view on what it does. But I think
we should not have the old model as well.

Removing early-binding at all might be a subject for PHP6, however in
PHP_5_3 we even keep ze1_compatibility_mode.
I'm not able to remove it.

[skiped]

I'll recheck the -e option. Probably I missied something there.

I did not see -e in the list of allowed flags. So it cannot work.

Then I don't understand you last comments about the patch.

Thanks. Dmitry.

18 years ago by Hannes Magnusson — view source — reply

unread

Removing early-binding at all might be a subject for PHP6, however in
PHP_5_3 we even keep ze1_compatibility_mode.

http://news.php.net/php.internals/36085

-Hannes

18 years ago by Pierre Joye — view source — reply

unread

On Fri, Mar 14, 2008 at 11:06 AM, Hannes Magnusson
hannes.magnusson@gmail.com wrote:

Removing early-binding at all might be a subject for PHP6, however in
PHP_5_3 we even keep ze1_compatibility_mode.

http://news.php.net/php.internals/36085

I don't see any sane reason not to remove it :)

--
Pierre
http://blog.thepimp.net | http://www.libgd.org

18 years ago by Marcus Boerger — view source — reply

unread

Hello Pierre,

it is unused code that does not work as intended and causes trouble. And
at leats it makes maintanance harder. So that is a very big reason to drop
it.

marcus

Friday, March 14, 2008, 11:11:06 AM, you wrote:

On Fri, Mar 14, 2008 at 11:06 AM, Hannes Magnusson
hannes.magnusson@gmail.com wrote:

Removing early-binding at all might be a subject for PHP6, however in
PHP_5_3 we even keep ze1_compatibility_mode.

http://news.php.net/php.internals/36085

I don't see any sane reason not to remove it :)

--
Pierre
http://blog.thepimp.net | http://www.libgd.org

Best regards,
Marcus

18 years ago by Pierre Joye — view source — reply

unread

Hello Pierre,

it is unused code that does not work as intended and causes trouble. And
at leats it makes maintanance harder. So that is a very big reason to drop
it.

Yes, I fully agree (you may have missed the "not" in my reply :-)

Cheers,

Pierre
http://blog.thepimp.net | http://www.libgd.org

18 years ago by Marcus Boerger — view source — reply

unread

Hello Pierre,

yep, stupid me. I got confused by your wording :-)

marcus

Friday, March 14, 2008, 4:42:32 PM, you wrote:

Hello Pierre,

it is unused code that does not work as intended and causes trouble. And
at leats it makes maintanance harder. So that is a very big reason to drop
it.

Yes, I fully agree (you may have missed the "not" in my reply :-)

Cheers,

Pierre
http://blog.thepimp.net | http://www.libgd.org

Best regards,
Marcus

18 years ago by Derick Rethans — view source — reply

unread

however in
PHP_5_3 we even keep ze1_compatibility_mode.
I'm not able to remove it.

WHy not? It's quite broken anyway.

Derick

--
Derick Rethans
http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org

18 years ago by Ilia Alshanetsky — view source — reply

unread

Keeping it seems fairly meaningless (it was a temporary hack anyway).
Since 5.1 (or possibly even late 5.0) releases much of the new
functionality ignores it anyway.

however in
PHP_5_3 we even keep ze1_compatibility_mode.
I'm not able to remove it.

WHy not? It's quite broken anyway.

Derick

--
Derick Rethans
http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org

--

Ilia Alshanetsky

18 years ago by Marcus Boerger — view source — reply

unread

Hello Dmitry,

Friday, March 14, 2008, 9:46:41 AM, you wrote:

Hi Marcus,

-----Original Message-----
From: Marcus Boerger [mailto:helly@php.net]
Sent: Thursday, March 13, 2008 9:27 PM
To: Dmitry Stogov
Cc: Andi Gutmans; Stas Malyshev; phpxcache; internals@lists.php.net
Subject: Re: [PHP-DEV] Patch for opcode caches

Hello Dmitry,

Monday, March 10, 2008, 1:48:05 PM, you wrote:

Hi Marcus,

-----Original Message-----
From: Marcus Boerger [mailto:helly@php.net]
Sent: Sunday, March 09, 2008 3:00 PM
To: Dmitry Stogov
Cc: Derick Rethans; internals Mailing List; Andi Gutmans; Stas
Malyshev; phpxcache
Subject: Re: [PHP-DEV] Patch for opcode caches

Hello Dmitry,

please don't apply. The patch looks rather rough and
untested (see
below).

It was tested at least with Zend products and xcache.

Good, I am just worried that we introduce different behavior.
We should just have one execution mode. Your change is better
now having a more detailed view on what it does. But I think
we should not have the old model as well.

Removing early-binding at all might be a subject for PHP6, however in
PHP_5_3 we even keep ze1_compatibility_mode.
I'm not able to remove it.

I do not want to remove early binding. In fact I always wanted to have
early binding as much as possible. Because that is faster and makes
compiler caches easier. So why slow down stuff? A Compiler cache wants
everythign as static as possible which means a compiler cache wants early
binding. This is also faster. So what are you proposing here?

Best regards,
Marcus

Patch for opcode caches View as Markdown

Cheers,

Cheers,