substr & substr_compare fix

17 years ago by Etienne Kneuss — view source — reply

unread

Hi,

please consider the following patches [1,2] that are supposed to fix

substr in 5_3
substr_compare in 5_3 and HEAD

It basically makes them not so strict about the length argument.

Regards

[1] http://patches.colder.ch/php-src/string_substr_5_3.patch?markup
[2] http://patches.colder.ch/php-src/string_substr_HEAD.patch?markup

--
Etienne Kneuss
http://www.colder.ch

Men never do evil so completely and cheerfully as
when they do it from a religious conviction.
-- Pascal

17 years ago by Nuno Lopes — view source — reply

unread

I like the patches. If noone complains please go ahead and commit them.

Thanks,
Nuno

----- Original Message -----
From: "Etienne Kneuss" colder@php.net
To: "php-dev" internals@lists.php.net
Sent: Monday, February 11, 2008 6:07 PM
Subject: [PHP-DEV] substr & substr_compare fix

Hi,

please consider the following patches [1,2] that are supposed to fix

substr in 5_3

substr_compare in 5_3 and HEAD

It basically makes them not so strict about the length argument.

Regards

[1] http://patches.colder.ch/php-src/string_substr_5_3.patch?markup
[2] http://patches.colder.ch/php-src/string_substr_HEAD.patch?markup

--
Etienne Kneuss
http://www.colder.ch