# substr & substr_compare fix

- Thread: https://externals.io/message/35391
- Original archive: https://news-web.php.net/php.internals/35391
- Started by Etienne Kneuss on 2008-02-11T18:07:34+00:00
- Messages: 2
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #35391 — Etienne Kneuss — 2008-02-11T18:07:34+00:00

URL: https://externals.io/message/35391#35391

Hi,

please consider the following patches [1,2] that are supposed to fix
1) substr in 5_3
2) substr_compare in 5_3 and HEAD

It basically makes them not so strict about the length argument.

Regards

[1] http://patches.colder.ch/php-src/string_substr_5_3.patch?markup
[2] http://patches.colder.ch/php-src/string_substr_HEAD.patch?markup

-- 
Etienne Kneuss
http://www.colder.ch

Men never do evil so completely and cheerfully as
when they do it from a religious conviction.
-- Pascal

---

## #35425 — Nuno Lopes — 2008-02-12T22:44:34+00:00

URL: https://externals.io/message/35391#35425 · In reply to: #35391

I like the patches. If noone complains please go ahead and commit them.

Thanks,
Nuno


----- Original Message ----- 
From: "Etienne Kneuss" <colder@php.net>
To: "php-dev" <internals@lists.php.net>
Sent: Monday, February 11, 2008 6:07 PM
Subject: [PHP-DEV] substr & substr_compare fix


> Hi,
> 
> please consider the following patches [1,2] that are supposed to fix
> 1) substr in 5_3
> 2) substr_compare in 5_3 and HEAD
> 
> It basically makes them not so strict about the length argument.
> 
> Regards
> 
> [1] http://patches.colder.ch/php-src/string_substr_5_3.patch?markup
> [2] http://patches.colder.ch/php-src/string_substr_HEAD.patch?markup
> 
> -- 
> Etienne Kneuss
> http://www.colder.ch