ZSTR and NULL problems again View as Markdown

Hello Everyne,

I have now removed the ZSTR() macros from the stream macros.

Andrei will you please test that it compiles now?

• Frank

Agreed.... Unless someone goes ahead and changes the get_line macro and

places that call it, I'll do so when I get to the end of my second
leg...

-Sara
----- Original Message -----
From: ""Wez Furlong"" kingwez@gmail.com
Newsgroups: php.internals
To: "Andrei Zmievski" andrei@gravitonic.com
Cc: "PHP Internals" internals@lists.php.net; "Dmitry Stogov"
dmitry@zend.com; "Frank M. Kromann" frank@kromann.info
Sent: Monday, April 24, 2006 10:46 PM
Subject: Re: [PHP-DEV] ZSTR and NULL problems again

I think ZSTR(buf) should not be present in the macro:

#define php_stream_get_line(stream, buf, maxlen, retlen)
_php_stream_get_line((stream), IS_STRING, (buf), (maxlen), 0,
(retlen) TSRMLS_CC)

Let the caller apply ZSTR() to the argument manually, if that is
required.

--Wez.

    #define php_stream_get_line(stream, buf, maxlen, retlen)

_php_stream_get_line((stream), IS_STRING, ZSTR(buf), (maxlen), 0,
(retlen) TSRMLS_CC)