Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:23011
Return-Path: <frank@kromann.info>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 58780 invoked by uid 1010); 28 Apr 2006 19:05:25 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 58765 invoked from network); 28 Apr 2006 19:05:24 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 28 Apr 2006 19:05:24 -0000
X-PHP-List-Original-Sender: frank@kromann.info
X-Host-Fingerprint: 64.186.239.125 c-064-186-239-125.oc1.redwire.net Linux 2.5 (sometimes 2.4) (4)
Received: from ([64.186.239.125:54113] helo=mail.kromann.info)
	by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP
	id 3E/A3-18514-47762544 for <internals@lists.php.net>; Fri, 28 Apr 2006 15:05:24 -0400
Received: from warp (www.kromann.info [64.186.239.115])
	by mail.kromann.info (Postfix) with SMTP id 51D214040AF;
	Fri, 28 Apr 2006 12:05:20 -0700 (PDT)
To: Sara Golemon <pollita@php.net>
Cc: "\"Wez Furlong\"" <kingwez@gmail.com>,
	Andrei Zmievski <andrei@gravitonic.com>, <internals@lists.php.net>
X-Mailer: Swwwing 2000
Message-ID: <11462511057600000@9866357972520000.9866341568840000>
MIME-Version: 1.0
Reply-To: "Frank M. Kromann" <frank@kromann.info>
Date: Fri, 28 Apr 2006 12:05:05 -0700
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] ZSTR and NULL problems again
From: frank@kromann.info ("Frank M. Kromann")

Hello Everyne,

I have now removed the ZSTR() macros from the stream macros.

Andrei will you please test that it compiles now?

- Frank

> Agreed.... Unless someone goes ahead and changes the get_line macro and

> places that call it, I'll do so when I get to the end of my second
leg...
> 
> -Sara
> ----- Original Message ----- 
> From: ""Wez Furlong"" <kingwez@gmail.com>
> Newsgroups: php.internals
> To: "Andrei Zmievski" <andrei@gravitonic.com>
> Cc: "PHP Internals" <internals@lists.php.net>; "Dmitry Stogov" 
> <dmitry@zend.com>; "Frank M. Kromann" <frank@kromann.info>
> Sent: Monday, April 24, 2006 10:46 PM
> Subject: Re: [PHP-DEV] ZSTR and NULL problems again
> 
> 
> I think ZSTR(buf) should not be present in the macro:
> 
> #define php_stream_get_line(stream, buf, maxlen, retlen)
>    _php_stream_get_line((stream), IS_STRING, (buf), (maxlen), 0,
>    (retlen) TSRMLS_CC)
> 
> Let the caller apply ZSTR() to the argument manually, if that is
required.
> 
> --Wez.
> 
> On 4/24/06, Andrei Zmievski <andrei@gravitonic.com> wrote:
> >         #define php_stream_get_line(stream, buf, maxlen, retlen)
> > _php_stream_get_line((stream), IS_STRING, ZSTR(buf), (maxlen), 0,
> > (retlen) TSRMLS_CC) 
> 
> 
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
> 
>