Compile fails now with ext/pgsql after your commits:
/usr/src/php5/ext/pgsql/pgsql.c: In function zm_startup_pgsql': /usr/src/php5/ext/pgsql/pgsql.c:494: error:PG_DIAG_INTERNAL_POSITION' undeclared (first use in this function)
/usr/src/php5/ext/pgsql/pgsql.c:494: error: (Each undeclared identifier is reported only once
/usr/src/php5/ext/pgsql/pgsql.c:494: error: for each function it appears in.)
/usr/src/php5/ext/pgsql/pgsql.c:495: error: PG_DIAG_INTERNAL_QUERY' undeclared (first use in this function) /usr/src/php5/ext/pgsql/pgsql.c: In functionzif_pg_result_error_field':
/usr/src/php5/ext/pgsql/pgsql.c:3488: error: PG_DIAG_INTERNAL_POSITION' undeclared (first use in this function) /usr/src/php5/ext/pgsql/pgsql.c:3488: error:PG_DIAG_INTERNAL_QUERY' undeclared (first use in this function)
make: *** [ext/pgsql/pgsql.lo] Error 1
Please fix ASAP.
--Jani
Sorry, just woke up...
Compile fails now with ext/pgsql after your commits:/usr/src/php5/ext/pgsql/pgsql.c: In function
zm_startup_pgsql': /usr/src/php5/ext/pgsql/pgsql.c:494: error:PG_DIAG_INTERNAL_POSITION'
undeclared (first use in this function)
/usr/src/php5/ext/pgsql/pgsql.c:494: error: (Each undeclared identifier
is reported only once
/usr/src/php5/ext/pgsql/pgsql.c:494: error: for each function it appears
in.)
/usr/src/php5/ext/pgsql/pgsql.c:495: error:PG_DIAG_INTERNAL_QUERY' undeclared (first use in this function) /usr/src/php5/ext/pgsql/pgsql.c: In functionzif_pg_result_error_field':
/usr/src/php5/ext/pgsql/pgsql.c:3488: error:PG_DIAG_INTERNAL_POSITION' undeclared (first use in this function) /usr/src/php5/ext/pgsql/pgsql.c:3488: error:PG_DIAG_INTERNAL_QUERY'
undeclared (first use in this function)
make: *** [ext/pgsql/pgsql.lo] Error 1
Is that all the failure messages? I cannot understand why 2 of the 12
diagnostic codes are not defined and the others are, given that they
were all added in one go in PostgreSQL 7.4??
What version of PostgreSQL libpq are you linking against?
Also, is this before or after I added the #if HAVE_PQRESULTERRORFIELD on
line 486 of pgsql.c?
Do these #defines appear in your include dir in postgres_ext.h on your
system?
Chris
/usr/src/php5/ext/pgsql/pgsql.c:3488: error:
PG_DIAG_INTERNAL_POSITION' undeclared (first use in this function) /usr/src/php5/ext/pgsql/pgsql.c:3488: error:PG_DIAG_INTERNAL_QUERY'Is that all the failure messages? I cannot understand why 2 of the 12
diagnostic codes are not defined and the others are, given that they were all
added in one go in PostgreSQL 7.4??
Yes, that was all.
What version of PostgreSQL libpq are you linking against?
7.4.7 (from the fedora core 3 rpms)
Also, is this before or after I added the #if HAVE_PQRESULTERRORFIELD on line
486 of pgsql.c?
After. I didn't try compiling before. :)
Do these #defines appear in your include dir in postgres_ext.h on your system?
No. Here's the whole section from it:
#define PG_DIAG_SEVERITY 'S'
#define PG_DIAG_SQLSTATE 'C'
#define PG_DIAG_MESSAGE_PRIMARY 'M'
#define PG_DIAG_MESSAGE_DETAIL 'D'
#define PG_DIAG_MESSAGE_HINT 'H'
#define PG_DIAG_STATEMENT_POSITION 'P'
#define PG_DIAG_CONTEXT 'W'
#define PG_DIAG_SOURCE_FILE 'F'
#define PG_DIAG_SOURCE_LINE 'L'
#define PG_DIAG_SOURCE_FUNCTION 'R'
--Jani
No. Here's the whole section from it: #define PG_DIAG_SEVERITY 'S' #define PG_DIAG_SQLSTATE 'C' #define PG_DIAG_MESSAGE_PRIMARY 'M' #define PG_DIAG_MESSAGE_DETAIL 'D' #define PG_DIAG_MESSAGE_HINT 'H' #define PG_DIAG_STATEMENT_POSITION 'P' #define PG_DIAG_CONTEXT 'W' #define PG_DIAG_SOURCE_FILE 'F' #define PG_DIAG_SOURCE_LINE 'L' #define PG_DIAG_SOURCE_FUNCTION 'R'
Hmmmm. Maybe the failing ones were added in 8.0... Let me check...
Chris
OK, fixed. Please test it.
I'll be out for an hour or two...
Christopher Kings-Lynne wrote:
No. Here's the whole section from it: #define PG_DIAG_SEVERITY 'S' #define PG_DIAG_SQLSTATE 'C' #define PG_DIAG_MESSAGE_PRIMARY 'M' #define PG_DIAG_MESSAGE_DETAIL 'D' #define PG_DIAG_MESSAGE_HINT 'H' #define PG_DIAG_STATEMENT_POSITION 'P' #define PG_DIAG_CONTEXT 'W' #define PG_DIAG_SOURCE_FILE 'F' #define PG_DIAG_SOURCE_LINE 'L' #define PG_DIAG_SOURCE_FUNCTION 'R'Hmmmm. Maybe the failing ones were added in 8.0... Let me check...
Chris
Yeah, compiles now. I fixed a small error in your fix
though. :)
--Jani
OK, fixed. Please test it.
I'll be out for an hour or two...
Christopher Kings-Lynne wrote:
No. Here's the whole section from it: #define PG_DIAG_SEVERITY 'S' #define PG_DIAG_SQLSTATE 'C' #define PG_DIAG_MESSAGE_PRIMARY 'M' #define PG_DIAG_MESSAGE_DETAIL 'D' #define PG_DIAG_MESSAGE_HINT 'H' #define PG_DIAG_STATEMENT_POSITION 'P' #define PG_DIAG_CONTEXT 'W' #define PG_DIAG_SOURCE_FILE 'F' #define PG_DIAG_SOURCE_LINE 'L' #define PG_DIAG_SOURCE_FUNCTION 'R'Hmmmm. Maybe the failing ones were added in 8.0... Let me check...
Chris