Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:15505
Return-Path: <chriskl@familyhealth.com.au>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 42604 invoked by uid 1010); 20 Mar 2005 01:54:57 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 42577 invoked from network); 20 Mar 2005 01:54:57 -0000
Received: from unknown (HELO pb1.pair.com) (127.0.0.1)
  by localhost with SMTP; 20 Mar 2005 01:54:57 -0000
X-Host-Fingerprint: 203.10.1.131 vscan01.westnet.com.au Linux 2.4/2.6
Received: from ([203.10.1.131:47609] helo=vscan01.westnet.com.au)
	by pb1.pair.com (ecelerity HEAD r(5268)) with SMTP
	id 83/E7-11294-DE7DC324 for <internals@lists.php.net>; Sat, 19 Mar 2005 20:54:54 -0500
Received: from localhost (localhost.localdomain [127.0.0.1])
	by localhost (Postfix) with ESMTP id E780514DCE9;
	Sun, 20 Mar 2005 09:54:25 +0800 (WST)
Received: from vscan01.westnet.com.au ([127.0.0.1])
	by localhost (vscan01.westnet.com.au [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 06197-19; Sun, 20 Mar 2005 09:54:25 +0800 (WST)
Received: from [202.72.133.22] (dsl-202-72-133-22.wa.westnet.com.au [202.72.133.22])
	by vscan01.westnet.com.au (Postfix) with ESMTP id 590BE14E589;
	Sun, 20 Mar 2005 09:54:25 +0800 (WST)
Message-ID: <423CD7E4.4080407@familyhealth.com.au>
Date: Sun, 20 Mar 2005 09:54:44 +0800
User-Agent: Mozilla Thunderbird 0.9 (Windows/20041103)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Jani Taskinen <sniper@iki.fi>
Cc: chriskl@php.net, internals@lists.php.net
References: <Pine.LNX.4.61.0503192315090.8219@arfg.argcubovn.sv>
In-Reply-To: <Pine.LNX.4.61.0503192315090.8219@arfg.argcubovn.sv>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] ext/pgsql build broken
From: chriskl@familyhealth.com.au (Christopher Kings-Lynne)

Sorry, just woke up...

>     Compile fails now with ext/pgsql after your commits:
> 
> /usr/src/php5/ext/pgsql/pgsql.c: In function `zm_startup_pgsql':
> /usr/src/php5/ext/pgsql/pgsql.c:494: error: `PG_DIAG_INTERNAL_POSITION' 
> undeclared (first use in this function)
> /usr/src/php5/ext/pgsql/pgsql.c:494: error: (Each undeclared identifier 
> is reported only once
> /usr/src/php5/ext/pgsql/pgsql.c:494: error: for each function it appears 
> in.)
> /usr/src/php5/ext/pgsql/pgsql.c:495: error: `PG_DIAG_INTERNAL_QUERY' 
> undeclared (first use in this function)
> /usr/src/php5/ext/pgsql/pgsql.c: In function `zif_pg_result_error_field':
> /usr/src/php5/ext/pgsql/pgsql.c:3488: error: `PG_DIAG_INTERNAL_POSITION' 
> undeclared (first use in this function)
> /usr/src/php5/ext/pgsql/pgsql.c:3488: error: `PG_DIAG_INTERNAL_QUERY' 
> undeclared (first use in this function)
> make: *** [ext/pgsql/pgsql.lo] Error 1

Is that all the failure messages?  I cannot understand why 2 of the 12 
diagnostic codes are not defined and the others are, given that they 
were all added in one go in PostgreSQL 7.4??

What version of PostgreSQL libpq are you linking against?

Also, is this before or after I added the #if HAVE_PQRESULTERRORFIELD on 
line 486 of pgsql.c?

Do these #defines appear in your include dir in postgres_ext.h on your 
system?

Chris