Implement SeekableIterator for SplObjectStorage

6 months ago by Niels Dossche — view source

unread

Hi internals

I opened a PR to make SplObjectStorage implement SeekableIterator, this means that it'll now be possible to use seek(int $offset): void on SplObjectStorage.
I'm mainly posting here to see if there are any objections.
PR link: https://github.com/php/php-src/pull/13665

Kind regards
Niels

6 months ago by Bruce Weirdan — view source

unread

I opened a PR to make SplObjectStorage implement SeekableIterator, this means that it'll now be possible to use seek(int $offset): void on SplObjectStorage

Note that it's a BC break for descendants of SplObjectStorage with an
incompatible seek() already implemented (e.g.
https://3v4l.org/uW9Yl), so it shouldn't happen in a patch release.
Not that I expect there to be many of those, but still.

--
Best regards,
Bruce Weirdan mailto:weirdan@gmail.com

6 months ago by Niels Dossche — view source

unread

Hi Bruce

I opened a PR to make SplObjectStorage implement SeekableIterator, this means that it'll now be possible to use seek(int $offset): void on SplObjectStorage

Note that it's a BC break for descendants of SplObjectStorage with an
incompatible seek() already implemented (e.g.
https://3v4l.org/uW9Yl), so it shouldn't happen in a patch release.

Indeed, that's why the PR is targeted to the master branch, i.e. PHP 8.4 :)

Not that I expect there to be many of those, but still.

--
Best regards,
Bruce Weirdan mailto:weirdan@gmail.com

Kind regards
Niels