Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122607
Message-ID: <4a89864d-095f-4243-a272-5b53184e9772@gmail.com>
Date: Sun, 10 Mar 2024 22:58:31 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] Implement SeekableIterator for SplObjectStorage
Content-Language: en-US
To: internals@lists.php.net
References: <53d425fc-a1d5-4ac2-b252-8a1c7fb3aeda@gmail.com>
 <CA+hqhpc1YpRVc9Kst+eyKMC9jDXqLgDr5juhGoFpO5u=Pr6-zA@mail.gmail.com>
In-Reply-To: <CA+hqhpc1YpRVc9Kst+eyKMC9jDXqLgDr5juhGoFpO5u=Pr6-zA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: dossche.niels@gmail.com (Niels Dossche)

Hi Bruce

On 10/03/2024 21:43, Bruce Weirdan wrote:
> On Sun, Mar 10, 2024 at 9:14 PM Niels Dossche <dossche.niels@gmail.com> wrote:
> 
>> I opened a PR to make SplObjectStorage implement SeekableIterator, this means that it'll now be possible to use `seek(int $offset): void` on SplObjectStorage
> 
> Note that it's a BC break for descendants of SplObjectStorage with an
> incompatible `seek()` already implemented (e.g.
> https://3v4l.org/uW9Yl), so it shouldn't happen in a patch release.

Indeed, that's why the PR is targeted to the master branch, i.e. PHP 8.4 :)

> Not that I expect there to be many of those, but still.
> 
> 
> 
> --
>   Best regards,
>       Bruce Weirdan                                     mailto:weirdan@gmail.com

Kind regards
Niels