Hi,
There were a number of build problems caused by my PR https://github.com/php/php-src/pull/4678https://github.com/php/php-src/pull/4678#issuecomment-532204164
Today I got another report from Remi https://github.com/php/php-src/commit/f633c347574c0d814050b4bf2493e0cac6a5988c
Although, the patch makes visible performance improvement, it's probably better to revert it and all the related fixes for PHP-7.4.
Thanks. Dmitry.
Hi Dmitry,
There were a number of build problems caused by my PR
https://github.com/php/php-src/pull/4678https://github.com/php/php-src/pull/4678#issuecomment-532204164Today I got another report from Remi
https://github.com/php/php-src/commit/f633c347574c0d814050b4bf2493e0cac6a5988c
Although, the patch makes visible performance improvement, it's
probably better to revert it and all the related fixes for PHP-7.4.
I think we should revert it (and the related) for PHP 7.4 indeed. We
have plenty of time for PHP 8 to see if we can properly address it
there. And now is not the time to be experimental with the
soon-to-be-released PHP 7.4.0.
cheers,
Derick
--
PHP 7.4 Release Manager
Host of PHP Internals News: https://phpinternals.news
Like Xdebug? Become my Patron: https://www.patreon.com/derickr
https://derickrethans.nl | https://xdebug.org | https://dram.io
twitter: @derickr and @xdebug
reverted
From: Derick Rethans derick@php.net
Sent: Thursday, October 10, 2019 13:11
To: Dmitry Stogov dmitry@zend.com
Cc: Peter Kokot petk@php.net; Nikita Popov nikic@php.net; 'Remi Collet' remi@php.net; PHP internals internals@lists.php.net
Subject: Re: [PHP-DEV] Reverting "Link executable files using non PIC object files"
CAUTION: This email originated from outside of the organization. Do not click on links or open attachments unless you recognize the sender and know the content is safe.
Hi Dmitry,
There were a number of build problems caused by my PR
https://github.com/php/php-src/pull/4678https://github.com/php/php-src/pull/4678#issuecomment-532204164Today I got another report from Remi
https://github.com/php/php-src/commit/f633c347574c0d814050b4bf2493e0cac6a5988c
Although, the patch makes visible performance improvement, it's
probably better to revert it and all the related fixes for PHP-7.4.
I think we should revert it (and the related) for PHP 7.4 indeed. We
have plenty of time for PHP 8 to see if we can properly address it
there. And now is not the time to be experimental with the
soon-to-be-released PHP 7.4.0.
cheers,
Derick
--
PHP 7.4 Release Manager
Host of PHP Internals News: https://phpinternals.news
Like Xdebug? Become my Patron: https://www.patreon.com/derickr
https://derickrethans.nl | https://xdebug.org | https://dram.io
twitter: @derickr and @xdebug