Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:107467
Return-Path: <derick@php.net>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 95806 invoked from network); 10 Oct 2019 12:29:04 -0000
Received: from unknown (HELO php-smtp3.php.net) (208.43.231.12)
  by pb1.pair.com with SMTP; 10 Oct 2019 12:29:04 -0000
Received: from php-smtp3.php.net (localhost [127.0.0.1])
	by php-smtp3.php.net (Postfix) with ESMTP id 5836B2D20EB
	for <internals@lists.php.net>; Thu, 10 Oct 2019 03:11:56 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp3.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS
	autolearn=no autolearn_force=no version=3.4.2
X-Spam-ASN: AS30827 82.113.144.0/21
X-Spam-Virus: No
Received: from xdebug.org (xdebug.org [82.113.146.227])
	by php-smtp3.php.net (Postfix) with ESMTP
	for <internals@lists.php.net>; Thu, 10 Oct 2019 03:11:55 -0700 (PDT)
Received: from localhost (localhost [IPv6:::1])
	by xdebug.org (Postfix) with ESMTPS id 0424910C9F5;
	Thu, 10 Oct 2019 11:11:54 +0100 (BST)
Date: Thu, 10 Oct 2019 11:11:54 +0100 (BST)
X-X-Sender: derick@singlemalt.home.derickrethans.nl
To: Dmitry Stogov <dmitry@zend.com>
cc: Peter Kokot <petk@php.net>, Nikita Popov <nikic@php.net>, 
    'Remi Collet' <remi@php.net>, PHP internals <internals@lists.php.net>
In-Reply-To: <MN2PR02MB57751ED73CA7297147362B1DBF9B0@MN2PR02MB5775.namprd02.prod.outlook.com>
Message-ID: <alpine.DEB.2.21.1910101110430.2807@singlemalt.home.derickrethans.nl>
References: <MN2PR02MB57751ED73CA7297147362B1DBF9B0@MN2PR02MB5775.namprd02.prod.outlook.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Envelope-From: <derick@php.net>
Subject: Re: [PHP-DEV] Reverting "Link executable files using non PIC object
 files"
From: derick@php.net (Derick Rethans)

Hi Dmitry,

On Mon, 7 Oct 2019, Dmitry Stogov wrote:

> There were a number of build problems caused by my PR 
> https://github.com/php/php-src/pull/4678<https://github.com/php/php-src/pull/4678#issuecomment-532204164>
> 
> Today I got another report from Remi 
> https://github.com/php/php-src/commit/f633c347574c0d814050b4bf2493e0cac6a5988c 
> Although, the patch makes visible performance improvement, it's 
> probably better to revert it and all the related fixes for PHP-7.4.

I think we should revert it (and the related) for PHP 7.4 indeed. We 
have plenty of time for PHP 8 to see if we can properly address it 
there. And now is not the time to be experimental with the 
soon-to-be-released PHP 7.4.0.

cheers,
Derick

-- 
PHP 7.4 Release Manager
Host of PHP Internals News: https://phpinternals.news
Like Xdebug? Become my Patron: https://www.patreon.com/derickr
https://derickrethans.nl | https://xdebug.org | https://dram.io
twitter: @derickr and @xdebug