unread
I've been walking through the PHP 7.2->7.3 ext/dom diffs but I don't see
what has caused this change: https://3v4l.org/hEmmR
What did I miss?
-Rasmus
PHP 7.3 dom change? View as Markdown
unread
I've been walking through the PHP 7.2->7.3 ext/dom diffs but I don't see
what has caused this change: https://3v4l.org/hEmmR
What did I miss?
Tracked it down to this bug fix: https://bugs.php.net/76285
-Rasmus
unread
On Mon, Apr 1, 2019 at 9:25 AM Rasmus Lerdorf rasmus@lerdorf.com
wrote:I've been walking through the PHP 7.2->7.3 ext/dom diffs but I
don't see
what has caused this change: https://3v4l.org/hEmmR
What did I miss?Tracked it down to this bug fix: https://bugs.php.net/76285
Ah, I recall this one now. It was about saveHtml() not respecting
format, had some follow ups, too. Should be harmless but might breach
some test. Please ping, if there is a further issue.
Regards
Anatol
unread
On Mon, Apr 1, 2019 at 9:25 AM Rasmus Lerdorf rasmus@lerdorf.com
wrote:I've been walking through the PHP 7.2->7.3 ext/dom diffs but I
don't see
what has caused this change: https://3v4l.org/hEmmR
What did I miss?Tracked it down to this bug fix: https://bugs.php.net/76285
Ah, I recall this one now. It was about saveHtml() not respecting
format, had some follow ups, too. Should be harmless but might breach
some test. Please ping, if there is a further issue.
Yeah, it broke some tests and there is no mention of it in the migration
docs.
-Rasmus