Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105036
MIME-Version: 1.0
References: <CACXBjuibZgCQofc3RhLpvREHMEYjLcXX-zc9DQ9RG4x3fZsZJg@mail.gmail.com>
 <CACXBjuia2z9+1JV9ZjGzECZ51jVh8-=NsYiTCe5dGTwxPkfk+A@mail.gmail.com> <DB6PR0501MB232620A3CFCB10A0052F93DFC0560@DB6PR0501MB2326.eurprd05.prod.outlook.com>
In-Reply-To: <DB6PR0501MB232620A3CFCB10A0052F93DFC0560@DB6PR0501MB2326.eurprd05.prod.outlook.com>
Date: Tue, 2 Apr 2019 07:08:49 -0700
Message-ID: <CACXBjuhEORNQHM73T1YZMne_q9wk6dkA7-bCUBfDQUa7HCV4bw@mail.gmail.com>
To: Anatol Belski <ab@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000059219405858cafcd"
Subject: Re: [PHP-DEV] Re: PHP 7.3 dom change?
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--00000000000059219405858cafcd
Content-Type: text/plain; charset="UTF-8"

On Tue, Apr 2, 2019 at 2:22 AM Anatol Belski <ab@php.net> wrote:

> On Mon, 2019-04-01 at 13:42 -0700, Rasmus Lerdorf wrote:
> > On Mon, Apr 1, 2019 at 9:25 AM Rasmus Lerdorf <rasmus@lerdorf.com>
> > wrote:
> >
> > > I've been walking through the PHP 7.2->7.3 ext/dom diffs but I
> > > don't see
> > > what has caused this change: https://3v4l.org/hEmmR
> > > What did I miss?
> > >
> >
> > Tracked it down to this bug fix:  https://bugs.php.net/76285
> >
> Ah, I recall this one now. It was about saveHtml() not respecting
> format, had some follow ups, too. Should be harmless but might breach
> some test. Please ping, if there is a further issue.
>

Yeah, it broke some tests and there is no mention of it in the migration
docs.

-Rasmus

--00000000000059219405858cafcd--