Merging new hash algorithm (crc32c) into PHP 7.3 and maybe 7.2?

Hi,

I've recently sent a pull request https://github.com/php/php-src/pull/3913,
to add a new hashing algorithm, http://php.net/manual/en/function.hash.php
specific crc32c (Castagnoli's polynomial). This variant of crc32 is heavily
used by storage systems, such as iSCSI, SCTP, Btrfs, ext4, and is
increasingly being used in APIs (such as Google Cloud Storage, and Apache
Kafka).

The hash algorithm is small, and self contained. It cleaning merges against
master, and the 7.2 branch. It was suggested that in addition to merging to
7.4, I could get approval to merge into 7.3 and maybe 7.2.

This email is to get approval for which versions it can be merged into.

thanks
Andrew

Hey PHP Team,

bump. Would I be able to get this small, and self contained change included
into 7.3 and/or 7.4?

thanks
Andrew

Hi,

I've recently sent a pull request
https://github.com/php/php-src/pull/3913, to add a new hashing
algorithm, http://php.net/manual/en/function.hash.php specific crc32c
(Castagnoli's polynomial). This variant of crc32 is heavily used by storage
systems, such as iSCSI, SCTP, Btrfs, ext4, and is increasingly being used
in APIs (such as Google Cloud Storage, and Apache Kafka).

The hash algorithm is small, and self contained. It cleaning merges
against master, and the 7.2 branch. It was suggested that in addition to
merging to 7.4, I could get approval to merge into 7.3 and maybe 7.2.

This email is to get approval for which versions it can be merged into.

thanks
Andrew

As both PHP 7.2 and 7.3 has been out for a while, -1 on this one.

Best,

Hey PHP Team,

bump. Would I be able to get this small, and self contained change included
into 7.3 and/or 7.4?

thanks
Andrew

Hi,

I've recently sent a pull request
https://github.com/php/php-src/pull/3913, to add a new hashing
algorithm, http://php.net/manual/en/function.hash.php specific crc32c
(Castagnoli's polynomial). This variant of crc32 is heavily used by
storage
systems, such as iSCSI, SCTP, Btrfs, ext4, and is increasingly being used
in APIs (such as Google Cloud Storage, and Apache Kafka).

The hash algorithm is small, and self contained. It cleaning merges
against master, and the 7.2 branch. It was suggested that in addition to
merging to 7.4, I could get approval to merge into 7.3 and maybe 7.2.

This email is to get approval for which versions it can be merged into.

thanks
Andrew

--
Gabriel Caruso

Am 10.03.2019 um 21:12 schrieb Gabriel Caruso:

As both PHP 7.2 and 7.3 has been out for a while, -1 on this one.

Same here; no new functionality should be added to already released versions.

Ok thanks everyone. Merging into master it is.

Thanks
Andrew

Am 10.03.2019 um 21:12 schrieb Gabriel Caruso:

As both PHP 7.2 and 7.3 has been out for a while, -1 on this one.

Same here; no new functionality should be added to already released
versions.

Hi,

don't forget the PHP-7.4 branch, which is not master (master is 8.0).

cheers,
Derick

Ok thanks everyone. Merging into master it is.

Thanks
Andrew

Am 10.03.2019 um 21:12 schrieb Gabriel Caruso:

As both PHP 7.2 and 7.3 has been out for a while, -1 on this one.

Same here; no new functionality should be added to already released
versions.

--

--
https://derickrethans.nl | https://xdebug.org | https://dram.io
Like Xdebug? Consider a donation: https://xdebug.org/donate.php,
or become my Patron: https://www.patreon.com/derickr
twitter: @derickr and @xdebug

Am 11.03.2019 um 15:20 schrieb Derick Rethans:

don't forget the PHP-7.4 branch, which is not master (master is 8.0).

Nikita already merged it into PHP-7.4 and master.