Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104630
Return-Path: <carusogabriel34@gmail.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 86365 invoked from network); 10 Mar 2019 23:22:54 -0000
Received: from unknown (HELO mail-wm1-f48.google.com) (209.85.128.48)
  by pb1.pair.com with SMTP; 10 Mar 2019 23:22:54 -0000
Received: by mail-wm1-f48.google.com with SMTP id g20so2316494wmh.5
        for <internals@lists.php.net>; Sun, 10 Mar 2019 13:12:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=8fufR7494Bau5L81vl7qgiA+LOZmXQf88WrMDyyaZyQ=;
        b=ZSI4dnk3Z3/a7d9qRy+MUDy3r3LfVCvih6DasLKxspFm6WQd7qtyDuHV5/eIIB2MQ+
         m56MA0XJyh/E4SmTcz7MBLlmFOkrA2FF0vg+DRobWZ3aSAvO0NYYDBCvUQS9XiT8eRZA
         f3WSAUKX8QmqBw3YJJVK5O3YlRlTG50DUeclIsExL5oTjIZxfsxdin1niWNB6CFI/LNQ
         enOLsCw1Vr6RWZiVqFQmcvRhOlVBZGO7TB+ovImwge+5280jMkc4hmnDf4J1bXUzlDYL
         nAlavYf/hfo1Wibymu7d1N2bS9Qg9VsBOi7kBxaF8gbMuBB1sgFAqmqOsrfDSQJrqtXs
         d3LA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=8fufR7494Bau5L81vl7qgiA+LOZmXQf88WrMDyyaZyQ=;
        b=SlnAIXg+x9b0POUKbEbj6Co48RjX8tp+FmpOjVamQ7v7y5zAoLi6bIwmnzJfsOxHx4
         LhB5/SzYmB+/F7bjqc9+aTDkPoUI8ANULxSRwsfcJuIJ6pjtVN3Npk9mAkfgYzNasg2T
         EvthKa2Rx5FQA3FrZN+Zfx2v4QSJD1i+Zm2LBA0er2uOnAVxwRMcenDLVtx3WRVSAv4q
         mpp+/TX3Tj81EvjqVSRmF9MS+Xh6ShJ/GNLfI0h1RYIxLWCZujwG/4MzWLT3ADV4TEY5
         oQK12o0Kjj9eatS1SXErEIs1V3MAO4JnqXg4hGXMad9MajTRQN3MGnpCFBfWfy7WJ2q1
         0IWg==
X-Gm-Message-State: APjAAAW5xqoWv0iHDgfe6Z7sDbKMs/vxpl5tOmHEl05yV9KOKbaxVNiv
	nXCG6WpGSmdMiXFU9yEIz9h5ttKe4RVHB09BkYI=
X-Google-Smtp-Source: APXvYqxG20E/d7RLiDq1oAuyO3ldC5QzwXuZkZsDl1PWhTjfpF3CFMeb6v/FScIE6qkLbQZvB8S9mQPh60h1vAGHgxc=
X-Received: by 2002:a1c:c187:: with SMTP id r129mr14778199wmf.107.1552248741389;
 Sun, 10 Mar 2019 13:12:21 -0700 (PDT)
MIME-Version: 1.0
References: <CAC2=hFAMSKt2D-Zu6FZnKivicLqXiExEhdRu=j6p5yOy5jx_Jw@mail.gmail.com>
 <CAC2=hFCoUaSaAU9YCD-N6WB0YGPnaZcdch_SnGgO5F2oQXpJuA@mail.gmail.com>
In-Reply-To: <CAC2=hFCoUaSaAU9YCD-N6WB0YGPnaZcdch_SnGgO5F2oQXpJuA@mail.gmail.com>
Date: Sun, 10 Mar 2019 17:12:07 -0300
Message-ID: <CAP=4hCJy4Zb4QR7t5mqh1cQKGRsaYONTM6=BBkqjr35fXW7sCw@mail.gmail.com>
To: Andrew Brampton <brampton@gmail.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000d5697a0583c3121a"
Subject: Re: [PHP-DEV] Re: Merging new hash algorithm (crc32c) into PHP 7.3
 and maybe 7.2?
From: carusogabriel34@gmail.com (Gabriel Caruso)

--000000000000d5697a0583c3121a
Content-Type: text/plain; charset="UTF-8"

As both PHP 7.2 and 7.3 has been out for a while, -1 on this one.

Best,
On Sun, 10 Mar 2019 at 15:50 Andrew Brampton <brampton@gmail.com> wrote:

> Hey PHP Team,
>
> bump. Would I be able to get this small, and self contained change included
> into 7.3 and/or 7.4?
>
> thanks
> Andrew
>
> On Tue, 5 Mar 2019 at 08:01, Andrew Brampton <brampton@gmail.com> wrote:
>
> > Hi,
> >
> > I've recently sent a pull request
> > <https://github.com/php/php-src/pull/3913>, to add a new hashing
> > algorithm, <http://php.net/manual/en/function.hash.php> specific crc32c
> > (Castagnoli's polynomial). This variant of crc32 is heavily used by
> storage
> > systems, such as iSCSI, SCTP, Btrfs, ext4, and is increasingly being used
> > in APIs (such as Google Cloud Storage, and Apache Kafka).
> >
> > The hash algorithm is small, and self contained. It cleaning merges
> > against master, and the 7.2 branch. It was suggested that in addition to
> > merging to 7.4, I could get approval to merge into 7.3 and maybe 7.2.
> >
> > This email is to get approval for which versions it can be merged into.
> >
> > thanks
> > Andrew
> >
> >
> >
>
-- 
Gabriel Caruso

--000000000000d5697a0583c3121a--