Thinking about https://github.com/sebastianbergmann/environment/issues/21
it just occured to me that PHP_OS_FAMILY currently contains "OSX".
Apple renamed (last year?) their "OS X" to "macOS". Should PHP_OS_FAMILY
not contain "macOS" then? Now would be the time to make that change
without breaking BC.
2017-06-13 7:20 GMT+02:00 Sebastian Bergmann sebastian@php.net:
Thinking about https://github.com/sebastianbergmann/environment/issues/21
it just occured to me that PHP_OS_FAMILY currently contains "OSX".Apple renamed (last year?) their "OS X" to "macOS". Should PHP_OS_FAMILY
not contain "macOS" then? Now would be the time to make that change
without breaking BC.
Apply changes it every few years, maybe we should just call it "Apple"? :D
Regards, Niklas
Hi
2017-06-13 8:00 GMT+02:00 Niklas Keller me@kelunik.com:
Apply changes it every few years, maybe we should just call it "Apple"? :D
I don't think that is all that bad an idea tbh, or simply "Mac"
--
regards,
Kalle Sommer Nielsen
kalle@php.net
-----Original Message-----
From: kalle.php@gmail.com [mailto:kalle.php@gmail.com] On Behalf Of Kalle
Sommer Nielsen
Sent: Tuesday, June 13, 2017 3:21 PM
To: Niklas Keller me@kelunik.com
Cc: PHP Internals internals@lists.php.net
Subject: Re: [PHP-DEV] PHP_OS_FAMILY and macOSHi
2017-06-13 8:00 GMT+02:00 Niklas Keller me@kelunik.com:
Apply changes it every few years, maybe we should just call it
"Apple"? :DI don't think that is all that bad an idea tbh, or simply "Mac"
Yep, Mac sounds like a fairly future-proof choice, and is also consistent with the capitalization of other options.
Zeev
Am 13.06.2017 um 15:00 schrieb Zeev Suraski:
Yep, Mac sounds like a fairly future-proof choice, and is also consistent with the capitalization of other options.
Implemented in
http://git.php.net/?p=php-src.git;a=commitdiff;h=362d2e42a02fe018a7d1261a53ff59b73fed91f6
Given that iPad (and iPhone) both run iOS which is based on Darwin, and
Apple just relaxed the rules on running interpreted code, and we are
already seeing IDEs spring up for the device, we should use "Darwin",
rather than "Mac". This also encompasses other distros like PureDarwin.
- Davey
On Tue, Jun 13, 2017 at 6:47 AM, Sebastian Bergmann sebastian@php.net
wrote:
Am 13.06.2017 um 15:00 schrieb Zeev Suraski:
Yep, Mac sounds like a fairly future-proof choice, and is also
consistent with the capitalization of other options.Implemented in
http://git.php.net/?p=php-src.git;a=commitdiff;h=
362d2e42a02fe018a7d1261a53ff59b73fed91f6
Am 13.06.2017 um 21:35 schrieb Davey Shafik:
Given that iPad (and iPhone) both run iOS which is based on Darwin, and
Apple just relaxed the rules on running interpreted code, and we are
already seeing IDEs spring up for the device, we should use "Darwin",
rather than "Mac". This also encompasses other distros like PureDarwin.
nice catch +1 from me
- Davey
On Tue, Jun 13, 2017 at 6:47 AM, Sebastian Bergmann sebastian@php.net
wrote:Am 13.06.2017 um 15:00 schrieb Zeev Suraski:
Yep, Mac sounds like a fairly future-proof choice, and is also
consistent with the capitalization of other options.Implemented in
http://git.php.net/?p=php-src.git;a=commitdiff;h=
362d2e42a02fe018a7d1261a53ff59b73fed91f6
Hi
2017-06-13 21:35 GMT+02:00 Davey Shafik davey@php.net:
Given that iPad (and iPhone) both run iOS which is based on Darwin, and
Apple just relaxed the rules on running interpreted code, and we are
already seeing IDEs spring up for the device, we should use "Darwin",
rather than "Mac". This also encompasses other distros like PureDarwin.
I agree, it makes a lot more sense than "Mac", I changed this to "Darwin":
http://git.php.net/?p=php-src.git;a=commit;h=a251d9b2c11c2ab53b0214d728c40d70cd06567c
--
regards,
Kalle Sommer Nielsen
kalle@php.net
Thinking about https://github.com/sebastianbergmann/environment/issues/21
it just occured to me that PHP_OS_FAMILY currently contains "OSX".Apple renamed (last year?) their "OS X" to "macOS". Should PHP_OS_FAMILY
not contain "macOS" then? Now would be the time to make that change
without breaking BC.
Changing it surely means breaking BC? I believe we should continue to
use OSX.
cheers,
Derick
Am 13.06.2017 um 14:40 schrieb Derick Rethans:
Changing it surely means breaking BC? I believe we should continue to
use OSX.
PHP_OS_FAMILY is new in PHP 7.2, which is not final yet.
Am 13.06.2017 um 14:40 schrieb Derick Rethans:
Changing it surely means breaking BC? I believe we should continue to
use OSX.PHP_OS_FAMILY is new in PHP 7.2, which is not final yet.
In that case, I agree with "macOS" as you suggested.
cheers,
Derick