Hi internals,
I've started the vote on https://wiki.php.net/rfc/deprecations_php_7_2. All
votes are 2/3 majority and end on 29-01-2017.
Thanks,
Nikita
Hi internals,
I've started the vote on https://wiki.php.net/rfc/deprecations_php_7_2.
All votes are 2/3 majority and end on 29-01-2017.Thanks,
Nikita
Voting has been closed, all of the proposals in this RFC have been accepted
within 2/3 majority.
For convenience of reference, the vote counts are as follows (Yes:No):
__autoload: 33:1
$php_errormsg: 29:0
create_function: 29:0
mbstring.func_overload: 28:0
(unset): 28:1
parse_str w/o 2nd arg: 29:0
gmp_random: 27:0
each: 18:6
assert w/ string: 25:1
$errcontext: 22:3
It looks like the each() deprecation was the only somewhat controversial
part of this RFC.
Nikita
I've started the vote on https://wiki.php.net/rfc/deprecations_php_7_2.
All votes are 2/3 majority and end on 29-01-2017.Voting has been closed, all of the proposals in this RFC have been accepted
within 2/3 majority.
What's the status here? Have all deprecations been implemented? The
RFC is still listed in the "Pending Implementation" section (
https://wiki.php.net/rfc#pending_implementation).
--
Christoph M. Becker
On Tue, Aug 8, 2017 at 5:43 PM, Christoph M. Becker cmbecker69@gmx.de
wrote:
On Sun, Jan 15, 2017 at 3:27 PM, Nikita Popov nikita.ppv@gmail.com
wrote:I've started the vote on https://wiki.php.net/rfc/deprecations_php_7_2.
All votes are 2/3 majority and end on 29-01-2017.Voting has been closed, all of the proposals in this RFC have been
accepted
within 2/3 majority.What's the status here? Have all deprecations been implemented? The
RFC is still listed in the "Pending Implementation" section (
https://wiki.php.net/rfc#pending_implementation).
Apart from the last item everything is implemented.
Nikita
On Tue, Aug 8, 2017 at 5:43 PM, Christoph M. Becker cmbecker69@gmx.de
wrote:On Sun, Jan 15, 2017 at 3:27 PM, Nikita Popov nikita.ppv@gmail.com
wrote:I've started the vote on https://wiki.php.net/rfc/deprecations_php_7_2.
All votes are 2/3 majority and end on 29-01-2017.Voting has been closed, all of the proposals in this RFC have been
accepted
within 2/3 majority.What's the status here? Have all deprecations been implemented? The
RFC is still listed in the "Pending Implementation" section (
https://wiki.php.net/rfc#pending_implementation).Apart from the last item everything is implemented.
Thanks, Nikita.
I assume that the $errcontext parameter of error handlers will not be
deprecated in PHP 7.2, but a later version. Would it make sense to
already document that the parameter shouldn't be used anymore (aka. soft
deprecation)?
--
Christoph M. Becker
Hi,
On Tue, Aug 8, 2017 at 5:43 PM, Christoph M. Becker cmbecker69@gmx.de
wrote:On Sun, Jan 15, 2017 at 3:27 PM, Nikita Popov nikita.ppv@gmail.com
wrote:I've started the vote on https://wiki.php.net/rfc/deprecations_php_7_2.
All votes are 2/3 majority and end on 29-01-2017.Voting has been closed, all of the proposals in this RFC have been
accepted
within 2/3 majority.What's the status here? Have all deprecations been implemented? The
RFC is still listed in the "Pending Implementation" section (
https://wiki.php.net/rfc#pending_implementation).Apart from the last item everything is implemented.
Thanks, Nikita.
I assume that the $errcontext parameter of error handlers will not be
deprecated in PHP 7.2, but a later version. Would it make sense to
already document that the parameter shouldn't be used anymore (aka. soft
deprecation)?
Actually, it's already documented as deprecated ... question is rather
whether that has to be reverted.
Cheers,
Andrey.
On Wed, Aug 9, 2017 at 5:23 PM, Christoph M. Becker cmbecker69@gmx.de
wrote:
On Tue, Aug 8, 2017 at 5:43 PM, Christoph M. Becker cmbecker69@gmx.de
wrote:On Sun, Jan 15, 2017 at 3:27 PM, Nikita Popov nikita.ppv@gmail.com
wrote:I've started the vote on https://wiki.php.net/rfc/
deprecations_php_7_2.
All votes are 2/3 majority and end on 29-01-2017.Voting has been closed, all of the proposals in this RFC have been
accepted
within 2/3 majority.What's the status here? Have all deprecations been implemented? The
RFC is still listed in the "Pending Implementation" section (
https://wiki.php.net/rfc#pending_implementation).Apart from the last item everything is implemented.
Thanks, Nikita.
I assume that the $errcontext parameter of error handlers will not be
deprecated in PHP 7.2, but a later version. Would it make sense to
already document that the parameter shouldn't be used anymore (aka. soft
deprecation)?
I'm not sure on this one. I think it might actually be preferable to keep
this as a documentation-only deprecation (and then directly remove it in
PHP 8). I'm not really happy with the proposed action from the RFC (even
though I suggested it myself), both in terms of behavior and implementation
complexity. There's a number of fun edge-cases there, like a __call()
method being used as error handler -- in that case the formal number of
parameters is 2, but more might actually be used and we have no way to
know. I don't even know what's supposed to happen in that case under the
RFC.
Nikita
On Wed, Aug 9, 2017 at 5:23 PM, Christoph M. Becker cmbecker69@gmx.de
wrote:I assume that the $errcontext parameter of error handlers will not be
deprecated in PHP 7.2, but a later version. Would it make sense to
already document that the parameter shouldn't be used anymore (aka. soft
deprecation)?I'm not sure on this one. I think it might actually be preferable to keep
this as a documentation-only deprecation (and then directly remove it in
PHP 8). I'm not really happy with the proposed action from the RFC (even
though I suggested it myself), both in terms of behavior and implementation
complexity. There's a number of fun edge-cases there, like a __call()
method being used as error handler -- in that case the formal number of
parameters is 2, but more might actually be used and we have no way to
know. I don't even know what's supposed to happen in that case under the
RFC.
Thanks for the explanation. In this case I'm fine with a "soft"
deprecation, but it should be mentioned in UPGRADING.
--
Christoph M. Becker
On Wed, Aug 9, 2017 at 7:23 PM, Christoph M. Becker cmbecker69@gmx.de
wrote:
On Wed, Aug 9, 2017 at 5:23 PM, Christoph M. Becker cmbecker69@gmx.de
wrote:I assume that the $errcontext parameter of error handlers will not be
deprecated in PHP 7.2, but a later version. Would it make sense to
already document that the parameter shouldn't be used anymore (aka. soft
deprecation)?I'm not sure on this one. I think it might actually be preferable to keep
this as a documentation-only deprecation (and then directly remove it in
PHP 8). I'm not really happy with the proposed action from the RFC (even
though I suggested it myself), both in terms of behavior and
implementation
complexity. There's a number of fun edge-cases there, like a __call()
method being used as error handler -- in that case the formal number of
parameters is 2, but more might actually be used and we have no way to
know. I don't even know what's supposed to happen in that case under the
RFC.Thanks for the explanation. In this case I'm fine with a "soft"
deprecation, but it should be mentioned in UPGRADING.
I've added a note in UPGRADING in
https://github.com/php/php-src/commit/b202587e099312e433c123331bb5fece94ec9670
and moved the RFC into the Implemented section.
Nikita