Greetings all,
It's been a while since we introduced the array_change_keys RFC
https://wiki.php.net/rfc/array_change_keys. During the discussion period
there was a healthy mix of interest and critique. It seems all the major
discussion points were covered, so I'd like to put this RFC to a vote to
determine its fate.
Therefore, voting is now open on the array_change_keys RFC:
https://wiki.php.net/rfc/array_change_keys Voting will close 2017-01-23 at
23:59:59 UTC.
Mailing list discussion thread:
https://marc.info/?l=php-internals&m=146452769326964&w=2
Reddit discussion thread:
https://www.reddit.com/r/PHP/comments/4ll1hg/rfc_array_change_keys/
The implementation is also on 3v4l.org should you wish to test it out.
Regards,
Colin O'Dell
Hi Colin,
Voting NO for the following reasons:
- Can be a userland function/library, unless there are huge performance
benefits that justify it being in core - Doesn't work with
iterable - New warnings. No, please, we want
Throwable: warnings are terrible - Semantics for merging duplicate keys should be part of the function
name, or a parameter (the former being better, having a strict version that
fails, and a merging version that overwrites) - I totally forgot that I benchmarked this before :-
https://github.com/Ocramius/array_change_keys-benchmark
Marco Pivetta
Greetings all,
It's been a while since we introduced the array_change_keys RFC
https://wiki.php.net/rfc/array_change_keys. During the discussion
period
there was a healthy mix of interest and critique. It seems all the major
discussion points were covered, so I'd like to put this RFC to a vote to
determine its fate.Therefore, voting is now open on the array_change_keys RFC:
https://wiki.php.net/rfc/array_change_keys Voting will close 2017-01-23
at
23:59:59 UTC.Mailing list discussion thread:
https://marc.info/?l=php-internals&m=146452769326964&w=2Reddit discussion thread:
https://www.reddit.com/r/PHP/comments/4ll1hg/rfc_array_change_keys/The implementation is also on 3v4l.org should you wish to test it out.
Regards,
Colin O'Dell
Hi Marco
2017-01-08 15:43 GMT+01:00 Marco Pivetta ocramius@gmail.com:
- New warnings. No, please, we want
Throwable: warnings are terrible
Only really chiming in for the warnings part; warnings should not be a
blocker for a new feature, because it would create an inconsistency
with that function and the rest. If we were to implement a Throwable
technique for such, then it should be done for everything instead,
like all ext/standard or ext/whatever and that is a lot of work, we
just need someone to start the movement if it is so desired.
--
regards,
Kalle Sommer Nielsen
kalle@php.net