couple of PRs for master

10 years ago by Ferenc Kovacs — view source — reply

unread

Hi,

I have a couple of pending PRs which are all small features with
outstanding bugreports/feature requests and I wasn't sure that they would
need an RFC or not, I would like to get some feedback about that:
https://github.com/php/php-src/pull/1214
https://github.com/php/php-src/pull/1204
https://github.com/php/php-src/pull/969

ps: they are all targeting master and I can merge them myself I just wanted
to make sure if they need further discussion or RFC.

--
Ferenc Kovács
@Tyr43l - http://tyrael.hu

10 years ago by Anthony Ferrara — view source — reply

unread

Fernec,

Hi,

I have a couple of pending PRs which are all small features with
outstanding bugreports/feature requests and I wasn't sure that they would
need an RFC or not, I would like to get some feedback about that:
https://github.com/php/php-src/pull/1214
https://github.com/php/php-src/pull/1204
https://github.com/php/php-src/pull/969

ps: they are all targeting master and I can merge them myself I just wanted
to make sure if they need further discussion or RFC.

--
Ferenc Kovács
@Tyr43l - http://tyrael.hu

IMHO they are all simple and self-contained enough not to really need
an RFC. We could bikeshed the function names, etc, but besides that I
don't see much that would warrant an RFC here (based on my
understanding/view on the process).

Thanks

Anthony

10 years ago by Anatol Belski — view source — reply

unread

Hi Ferenc,

-----Original Message-----
From: Ferenc Kovacs [mailto:tyra3l@gmail.com]
Sent: Wednesday, October 7, 2015 4:14 PM
To: PHP Internals internals@lists.php.net
Subject: [PHP-DEV] couple of PRs for master

Hi,

I have a couple of pending PRs which are all small features with outstanding
bugreports/feature requests and I wasn't sure that they would need an RFC or
not, I would like to get some feedback about that:
https://github.com/php/php-src/pull/1214
https://github.com/php/php-src/pull/1204
https://github.com/php/php-src/pull/969

ps: they are all targeting master and I can merge them myself I just wanted to
make sure if they need further discussion or RFC.

IMO it is fine to take the PRs as is into master. Since those are FRs and small, that's fine.

Regards

Anatol

10 years ago by Stanislav Malyshev — view source — reply

unread

Hi!

I have a couple of pending PRs which are all small features with
outstanding bugreports/feature requests and I wasn't sure that they would
need an RFC or not, I would like to get some feedback about that:
https://github.com/php/php-src/pull/1214
https://github.com/php/php-src/pull/1204
https://github.com/php/php-src/pull/969

Those look uncontroversial (except for comments but I trust you'd adress
those) and simple so I don't think it needs RFC.

--
Stas Malyshev
smalyshev@gmail.com