Behavior of classes type hinting together with the error handler

11 years ago by kluev.andrew@gmail.com — view source — reply

unread

Hello internals! My name is Andrew and I write php literally since
childhood (something around 10 years),
now PHP - is my profession.
And today once again debugging foreign code, I was ready to go to the
hospital to see a psychiatrist.
First, some of the code:
Do you think that can output this feature?

function test(A $a)
{
var_dump(get_class($a));
}

I always thought that only 'string (1) "A"', I have never been so wrong (c).

The code below will display 'string (1) "B"'

class A {
}

class B {
public $id = 1;
}

set_error_handler(function () {
return true;
});

function test(A $a)
{
var_dump(get_class($a));
}

test(new B());

I think this is very unexpected behavior, and suggest you to consider the
possibility of removing this behavior in PHP7.

Best regards.
Andrew Kluev.

11 years ago by Nikita Popov — view source — reply

unread

On Fri, Mar 13, 2015 at 12:48 PM, Андрей Клюев kluev.andrew@gmail.com
wrote:

Hello internals! My name is Andrew and I write php literally since
childhood (something around 10 years),
now PHP - is my profession.
And today once again debugging foreign code, I was ready to go to the
hospital to see a psychiatrist.
First, some of the code:
Do you think that can output this feature?

function test(A $a)
{
var_dump(get_class($a));
}

I always thought that only 'string (1) "A"', I have never been so wrong
(c).

The code below will display 'string (1) "B"'

class A {
}

class B {
public $id = 1;
}

set_error_handler(function () {
return true;
});

function test(A $a)
{
var_dump(get_class($a));
}

test(new B());

I think this is very unexpected behavior, and suggest you to consider the
possibility of removing this behavior in PHP7.

It has already been dropped by
https://wiki.php.net/rfc/engine_exceptions_for_php7 :)

As a side node, an "A $a" typehint does not make sure that get_class($a)
=== 'A', only that $a instanceof A.

Nikita

11 years ago by Andrew Kluev — view source — reply

unread

Oh! Thanks Nikita. I did not know that the exceptions in the engine already
accepted. But in fairness, in PHP "A $a" typehint does not make sure that
"$a instanceof A " returns true. You can change "test" fucntion in code
form my first message to

function test(A $a)
{
var_dump($a instanceof A);
}

Output will be "bool(false)".

Today I will try to recompile my PHP7, but with the exception of the engine
and try to reproduce this behavior. I have a view that it will be possible
to make.

11 years ago by Andrew Kluev — view source — reply

unread

Sorry for hype.
If found this text in Engine Exceptions RFC just now
TheE_RECOVERABLE_ERRORpart of the proposal may introduce a minor BC break, because it will no longer allow to silently ignore recoverable errors with a custom error handler. As this point is somewhat controversial I'll have a separate voting option for this.

It's realy cool! Thanks you!

Best regards.
Andrew Kluev.

2015-03-13 15:40 GMT+03:00 Andrew Kluev kluev.andrew@gmail.com:

Oh! Thanks Nikita. I did not know that the exceptions in the engine
already accepted. But in fairness, in PHP "A $a" typehint does not make
sure that "$a instanceof A " returns true. You can change "test" fucntion
in code form my first message to

function test(A $a)
{
var_dump($a instanceof A);
}

Output will be "bool(false)".

Today I will try to recompile my PHP7, but with the exception of the
engine and try to reproduce this behavior. I have a view that it will be
possible to make.